From: Marc Zyngier <maz@kernel•org>
To: Sean Christopherson <seanjc@google•com>
Cc: Oliver Upton <oupton@kernel•org>,
Tianrui Zhao <zhaotianrui@loongson•cn>,
Bibo Mao <maobibo@loongson•cn>,
Huacai Chen <chenhuacai@kernel•org>,
Madhavan Srinivasan <maddy@linux•ibm.com>,
Anup Patel <anup@brainfault•org>, Paul Walmsley <pjw@kernel•org>,
Palmer Dabbelt <palmer@dabbelt•com>,
Albert Ou <aou@eecs•berkeley.edu>,
Christian Borntraeger <borntraeger@linux•ibm.com>,
Janosch Frank <frankja@linux•ibm.com>,
Claudio Imbrenda <imbrenda@linux•ibm.com>,
Paolo Bonzini <pbonzini@redhat•com>,
linux-arm-kernel@lists•infradead.org, kvmarm@lists•linux.dev,
kvm@vger•kernel.org, loongarch@lists•linux.dev,
linux-mips@vger•kernel.org, linuxppc-dev@lists•ozlabs.org,
kvm-riscv@lists•infradead.org, linux-riscv@lists•infradead.org,
linux-kernel@vger•kernel.org,
"Gustavo A . R . Silva" <gustavoars@kernel•org>
Subject: Re: [PATCH] KVM: Remove subtle "struct kvm_stats_desc" pseudo-overlay
Date: Mon, 08 Dec 2025 10:42:15 +0000 [thread overview]
Message-ID: <865xahp854.wl-maz@kernel.org> (raw)
In-Reply-To: <20251205232655.445294-1-seanjc@google.com>
On Fri, 05 Dec 2025 23:26:55 +0000,
Sean Christopherson <seanjc@google•com> wrote:
>
> Remove KVM's internal pseudo-overlay of kvm_stats_desc, which subtly
> aliases the flexible name[] in the uAPI definition with a fixed-size array
> of the same name. The unusual embedded structure results in compiler
> warnings due to -Wflex-array-member-not-at-end, and also necessitates an
> extra level of dereferencing in KVM. To avoid the "overlay", define the
> uAPI structure to have a fixed-size name when building for the kernel.
>
> Opportunistically clean up the indentation for the stats macros, and
> replace spaces with tabs.
>
> No functional change intended.
>
> Reported-by: Gustavo A. R. Silva <gustavoars@kernel•org>
> Closes: https://lore.kernel.org/all/aPfNKRpLfhmhYqfP@kspp
> Signed-off-by: Sean Christopherson <seanjc@google•com>
Acked-by: Marc Zyngier <maz@kernel•org>
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2025-12-08 10:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-05 23:26 [PATCH] KVM: Remove subtle "struct kvm_stats_desc" pseudo-overlay Sean Christopherson
2025-12-06 3:38 ` Gustavo A. R. Silva
2025-12-06 8:16 ` Bibo Mao
2025-12-07 5:14 ` Anup Patel
2025-12-08 10:32 ` Christian Borntraeger
2025-12-08 10:42 ` Marc Zyngier [this message]
2026-01-12 17:38 ` Sean Christopherson
2026-03-24 6:07 ` patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=865xahp854.wl-maz@kernel.org \
--to=maz@kernel$(echo .)org \
--cc=anup@brainfault$(echo .)org \
--cc=aou@eecs$(echo .)berkeley.edu \
--cc=borntraeger@linux$(echo .)ibm.com \
--cc=chenhuacai@kernel$(echo .)org \
--cc=frankja@linux$(echo .)ibm.com \
--cc=gustavoars@kernel$(echo .)org \
--cc=imbrenda@linux$(echo .)ibm.com \
--cc=kvm-riscv@lists$(echo .)infradead.org \
--cc=kvm@vger$(echo .)kernel.org \
--cc=kvmarm@lists$(echo .)linux.dev \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mips@vger$(echo .)kernel.org \
--cc=linux-riscv@lists$(echo .)infradead.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=loongarch@lists$(echo .)linux.dev \
--cc=maddy@linux$(echo .)ibm.com \
--cc=maobibo@loongson$(echo .)cn \
--cc=oupton@kernel$(echo .)org \
--cc=palmer@dabbelt$(echo .)com \
--cc=pbonzini@redhat$(echo .)com \
--cc=pjw@kernel$(echo .)org \
--cc=seanjc@google$(echo .)com \
--cc=zhaotianrui@loongson$(echo .)cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox