Subject: Re: [PATCH v1 04/12] mm/memory_hotplug: remove nid parameter from arch_remove_memory()

From: Michael Ellerman <[email-masked]>
Date: Tue, 08 Jun 2021 20:50:21 +1000

David Hildenbrand <[email-masked]> writes:

> The parameter is unused, let's remove it.
>
> Cc: Catalin Marinas <[email-masked]>
> Cc: Will Deacon <[email-masked]>
> Cc: Michael Ellerman <[email-masked]>
> Cc: Benjamin Herrenschmidt <[email-masked]>
> Cc: Paul Mackerras <[email-masked]>
> Cc: Heiko Carstens <[email-masked]>
> Cc: Vasily Gorbik <[email-masked]>
> Cc: Christian Borntraeger <[email-masked]>
> Cc: Yoshinori Sato <[email-masked]>
> Cc: Rich Felker <[email-masked]>
> Cc: Dave Hansen <[email-masked]>
> Cc: Andy Lutomirski <[email-masked]>
> Cc: Peter Zijlstra <[email-masked]>
> Cc: Thomas Gleixner <[email-masked]>
> Cc: Ingo Molnar <[email-masked]>
> Cc: Borislav Petkov <[email-masked]>
> Cc: [email-masked]
> Cc: "H. Peter Anvin" <[email-masked]>
> Cc: Andrew Morton <[email-masked]>
> Cc: Anshuman Khandual <[email-masked]>
> Cc: Ard Biesheuvel <[email-masked]>
> Cc: Mike Rapoport <[email-masked]>
> Cc: Nicholas Piggin <[email-masked]>
> Cc: Pavel Tatashin <[email-masked]>
> Cc: Baoquan He <[email-masked]>
> Cc: Laurent Dufour <[email-masked]>
> Cc: Sergei Trofimovich <[email-masked]>
> Cc: Kefeng Wang <[email-masked]>
> Cc: Michel Lespinasse <[email-masked]>
> Cc: Christophe Leroy <[email-masked]>
> Cc: "Aneesh Kumar K.V" <[email-masked]>
> Cc: Thiago Jung Bauermann <[email-masked]>
> Cc: Joe Perches <[email-masked]>
> Cc: Pierre Morel <[email-masked]>
> Cc: Jia He <[email-masked]>
> Cc: [email-masked]
> Cc: [email-masked]
> Cc: [email-masked]
> Cc: [email-masked]
> Cc: [email-masked]
> Signed-off-by: David Hildenbrand <[email-masked]>
> ---
>  arch/arm64/mm/mmu.c            | 3 +--
>  arch/ia64/mm/init.c            | 3 +--
>  arch/powerpc/mm/mem.c          | 3 +--
>  arch/s390/mm/init.c            | 3 +--
>  arch/sh/mm/init.c              | 3 +--
>  arch/x86/mm/init_32.c          | 3 +--
>  arch/x86/mm/init_64.c          | 3 +--
>  include/linux/memory_hotplug.h | 3 +--
>  mm/memory_hotplug.c            | 4 ++--
>  mm/memremap.c                  | 5 +----
>  10 files changed, 11 insertions(+), 22 deletions(-)
>
...
> diff --git a/arch/powerpc/mm/mem.c b/arch/powerpc/mm/mem.c
> index 043bbeaf407c..fc5c36189c26 100644
> --- a/arch/powerpc/mm/mem.c
> +++ b/arch/powerpc/mm/mem.c
> @@ -115,8 +115,7 @@ int __ref arch_add_memory(int nid, u64 start, u64 size,
>  	return rc;
>  }
>  
> -void __ref arch_remove_memory(int nid, u64 start, u64 size,
> -			      struct vmem_altmap *altmap)
> +void __ref arch_remove_memory(u64 start, u64 size, struct vmem_altmap *altmap)
>  {
>  	unsigned long start_pfn = start >> PAGE_SHIFT;
>  	unsigned long nr_pages = size >> PAGE_SHIFT;

Acked-by: Michael Ellerman <[email-masked]> (powerpc)

cheers