public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@kernel•org>
To: Arnd Bergmann <arnd@arndb•de>, viro@zeniv•linux.org.uk
Cc: linux-fsdevel@vger•kernel.org, Arnd Bergmann <arnd@arndb•de>,
	Frederic Barrat <fbarrat@linux•vnet.ibm.com>,
	Andrew Donnellan <andrew.donnellan@au1•ibm.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
	Frank Haverkamp <haver@linux•vnet.ibm.com>,
	"Guilherme G. Piccoli" <gpiccoli@linux•vnet.ibm.com>,
	Kashyap Desai <kashyap.desai@broadcom•com>,
	Sumit Saxena <sumit.saxena@broadcom•com>,
	Shivasharan S <shivasharan.srikanteshwara@broadcom•com>,
	"James E.J. Bottomley" <jejb@linux•vnet.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle•com>,
	linuxppc-dev@lists•ozlabs.org, linux-kernel@vger•kernel.org,
	megaraidlinux.pdl@broadcom•com, linux-scsi@vger•kernel.org,
	linux-usb@vger•kernel.org
Subject: Re: [PATCH v2 03/17] compat_ioctl: use correct compat_ptr() translation in drivers
Date: Thu, 13 Sep 2018 14:03:18 +0300	[thread overview]
Message-ID: <871s9x1wy1.fsf@linux.intel.com> (raw)
In-Reply-To: <20180912150142.157913-3-arnd@arndb.de>

[-- Attachment #1: Type: text/plain, Size: 590 bytes --]

Arnd Bergmann <arnd@arndb•de> writes:

> A handful of drivers all have a trivial wrapper around their ioctl
> handler, but don't call the compat_ptr() conversion function at the
> moment. In practice this does not matter, since none of them are used
> on the s390 architecture and for all other architectures, compat_ptr()
> does not do anything, but using the new generic_compat_ioctl_ptrarg
> helper makes it more correct in theory, and simplifies the code.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb•de>

Acked-by: Felipe Balbi <felipe.balbi@linux•intel.com>

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  parent reply	other threads:[~2018-09-13 11:03 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20180912150142.157913-1-arnd@arndb.de>
2018-09-12 15:01 ` [PATCH v2 03/17] compat_ioctl: use correct compat_ptr() translation in drivers Arnd Bergmann
2018-09-12 18:13   ` Greg Kroah-Hartman
2018-09-13  0:48   ` Andrew Donnellan
2018-09-13 11:03   ` Felipe Balbi [this message]
2018-09-12 15:08 ` [PATCH v2 05/17] compat_ioctl: move more drivers to generic_compat_ioctl_ptrarg Arnd Bergmann
2018-09-12 15:56   ` Jason Gunthorpe
2018-09-12 15:58   ` Daniel Vetter
2018-09-12 16:01   ` Mauro Carvalho Chehab
2018-09-12 18:13   ` Greg Kroah-Hartman
2018-09-14 14:23   ` David Sterba
2018-09-14 20:35   ` Darren Hart
2018-09-14 20:57     ` Al Viro
2018-09-18 17:51       ` Darren Hart
2018-09-18 17:59         ` Jason Gunthorpe
2018-09-24 20:18           ` Arnd Bergmann
2018-09-24 20:35             ` Jason Gunthorpe
2018-09-24 21:17               ` Arnd Bergmann
2018-09-17  9:33   ` Jonathan Cameron
2018-10-06  7:05   ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871s9x1wy1.fsf@linux.intel.com \
    --to=balbi@kernel$(echo .)org \
    --cc=andrew.donnellan@au1$(echo .)ibm.com \
    --cc=arnd@arndb$(echo .)de \
    --cc=fbarrat@linux$(echo .)vnet.ibm.com \
    --cc=gpiccoli@linux$(echo .)vnet.ibm.com \
    --cc=gregkh@linuxfoundation$(echo .)org \
    --cc=haver@linux$(echo .)vnet.ibm.com \
    --cc=jejb@linux$(echo .)vnet.ibm.com \
    --cc=kashyap.desai@broadcom$(echo .)com \
    --cc=linux-fsdevel@vger$(echo .)kernel.org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-scsi@vger$(echo .)kernel.org \
    --cc=linux-usb@vger$(echo .)kernel.org \
    --cc=linuxppc-dev@lists$(echo .)ozlabs.org \
    --cc=martin.petersen@oracle$(echo .)com \
    --cc=megaraidlinux.pdl@broadcom$(echo .)com \
    --cc=shivasharan.srikanteshwara@broadcom$(echo .)com \
    --cc=sumit.saxena@broadcom$(echo .)com \
    --cc=viro@zeniv$(echo .)linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox