From: ebiederm@xmission•com (Eric W. Biederman)
To: Thiago Jung Bauermann <bauerman@linux•vnet.ibm.com>
Cc: kexec@lists•infradead.org, linux-security-module@vger•kernel.org,
linux-ima-devel@lists•sourceforge.net,
linuxppc-dev@lists•ozlabs.org, linux-kernel@vger•kernel.org,
Dave Young <dyoung@redhat•com>, Vivek Goyal <vgoyal@redhat•com>,
Baoquan He <bhe@redhat•com>,
Michael Ellerman <mpe@ellerman•id.au>,
Stewart Smith <stewart@linux•vnet.ibm.com>,
Mimi Zohar <zohar@linux•vnet.ibm.com>,
Eric Richter <erichte@linux•vnet.ibm.com>,
Andrew Morton <akpm@linux-foundation•org>,
Balbir Singh <bsingharora@gmail•com>
Subject: Re: [PATCH v4 0/5] kexec_file: Add buffer hand-over for the next kernel
Date: Wed, 07 Sep 2016 09:19:40 -0500 [thread overview]
Message-ID: <871t0vlrlv.fsf@x220.int.ebiederm.org> (raw)
In-Reply-To: <8760q7lswz.fsf@x220.int.ebiederm.org> (Eric W. Biederman's message of "Wed, 07 Sep 2016 08:51:24 -0500")
ebiederm@xmission•com (Eric W. Biederman) writes:
> Thiago Jung Bauermann <bauerman@linux•vnet.ibm.com> writes:
>
>> Hello,
>>
>> The purpose of this new version of the series is to fix a small issue that
>> I found, which is that the kernel doesn't remove the memory reservation
>> for the hand-over buffer it received from the previous kernel in the
>> device tree it sets up for the next kernel. The result is that for each
>> successive kexec, a stale hand-over buffer is left behind, wasting memory.
>>
>> This is fixed by changes to kexec_free_handover_buffer and
>> setup_handover_buffer in patch 2. The other change is to fix checkpatch
>> warnings in the last patch.
>
> This is fundamentally broken. You do not increase the integrity of a
> system by dropping integrity checks.
>
> No. No. No. No.
>
> Nacked-by: "Eric W. Biederman" <ebiederm@xmission•com>
To be constructive the way we have handled similiar situations in the
past (hotplu memory) is to call kexec_load again.
Eric
next prev parent reply other threads:[~2016-09-07 14:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 17:45 [PATCH v4 0/5] kexec_file: Add buffer hand-over for the next kernel Thiago Jung Bauermann
2016-08-30 17:45 ` [PATCH v4 1/5] kexec_file: Add buffer hand-over support " Thiago Jung Bauermann
2016-08-30 17:45 ` [PATCH v4 2/5] powerpc: " Thiago Jung Bauermann
2016-08-30 17:45 ` [PATCH v4 3/5] kexec_file: Allow skipping checksum calculation for some segments Thiago Jung Bauermann
2016-09-07 1:30 ` Eric W. Biederman
2016-08-30 17:45 ` [PATCH v4 4/5] kexec_file: Add mechanism to update kexec segments Thiago Jung Bauermann
2016-08-30 17:45 ` [PATCH v4 5/5] IMA: Demonstration code for kexec buffer passing Thiago Jung Bauermann
2016-09-07 13:51 ` [PATCH v4 0/5] kexec_file: Add buffer hand-over for the next kernel Eric W. Biederman
2016-09-07 14:19 ` Eric W. Biederman [this message]
2016-09-08 19:20 ` Thiago Jung Bauermann
2016-09-09 4:07 ` Eric W. Biederman
2016-09-09 13:08 ` Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871t0vlrlv.fsf@x220.int.ebiederm.org \
--to=ebiederm@xmission$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=bauerman@linux$(echo .)vnet.ibm.com \
--cc=bhe@redhat$(echo .)com \
--cc=bsingharora@gmail$(echo .)com \
--cc=dyoung@redhat$(echo .)com \
--cc=erichte@linux$(echo .)vnet.ibm.com \
--cc=kexec@lists$(echo .)infradead.org \
--cc=linux-ima-devel@lists$(echo .)sourceforge.net \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-security-module@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mpe@ellerman$(echo .)id.au \
--cc=stewart@linux$(echo .)vnet.ibm.com \
--cc=vgoyal@redhat$(echo .)com \
--cc=zohar@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox