Subject: Re: [PATCH v2] powerpc: implement support for MPC8349-compatible SOC GPIOs

From: Peter Korsgaard <[email-masked]>
Date: Wed, 17 Sep 2008 21:30:16 +0200

>>>>> "Anton" == Anton Vorontsov <[email-masked]> writes:

Hi,

 Anton> This patch implements GPIOLIB support for MPC8349-compatible SOC GPIOs.
 Anton> MPC8610 adopted this GPIO unit, so let's place it into sysdev.

 Anton> We'll need these gpios to support IrDA transceiver on MPC8610HPCD.

It seems basically the same as my patch (gpio driver for
mpc831x/mpc834x/mpc837x with OF bindings) from September 5th except
you don't have any documentation and the Kconfig doesn't depend on
831x/834x/837x.

Galak, did you have time to look at these patches yet?

 Anton> +struct fsl_gpio_chip {
 Anton> +	struct of_mm_gpio_chip mm_gc;
 Anton> +	spinlock_t lock;
 Anton> +
 Anton> +	/* shadowed data register to clear/set bits safely */
 Anton> +	u32 gpdat;

Why do you need this when you have the lock?

-- 
Bye, Peter Korsgaard