From: Peter Korsgaard <jacmet@sunsite•dk>
To: John Linn <john.linn@xilinx•com>
Cc: Sadanand <sadanan@xilinx•com>,
dmitry.torokhov@gmail•com, linuxppc-dev@ozlabs•org,
linux-input@vger•kernel.org
Subject: Re: [PATCH] [V2] powerpc: Xilinx: PS2: driver updates based on review
Date: Fri, 11 Jul 2008 08:35:41 +0200 [thread overview]
Message-ID: <871w21lygy.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20080710193451.ED2B51D18066@mail97-dub.bigfish.com> (John Linn's message of "Thu\, 10 Jul 2008 12\:34\:43 -0700")
>>>>> "John" == John Linn <john.linn@xilinx•com> writes:
John> Review comments were incorporated to improve the driver.
John> 1. Some data was eliminated that was not needed.
John> 2. Renaming of variables for clarity.
John> 3. Removed unneeded type casting.
John> 4. Changed to use dev_err rather than other I/O.
John> 5. Merged together some functions.
John> 6. Added kerneldoc format to functions.
John> Signed-off-by: Sadanand <sadanan@xilinx•com>
John> Signed-off-by: John Linn <john.linn@xilinx•com>
Acked-by: Peter Korsgaard <jacmet@sunsite•dk>
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2008-07-11 6:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-10 19:34 [PATCH] [V2] powerpc: Xilinx: PS2: driver updates based on review John Linn
2008-07-11 6:35 ` Peter Korsgaard [this message]
2008-07-11 14:45 ` Grant Likely
2008-07-24 3:37 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871w21lygy.fsf@macbook.be.48ers.dk \
--to=jacmet@sunsite$(echo .)dk \
--cc=dmitry.torokhov@gmail$(echo .)com \
--cc=john.linn@xilinx$(echo .)com \
--cc=linux-input@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=sadanan@xilinx$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox