From: Michael Ellerman <mpe@ellerman•id.au>
To: Arnd Bergmann <arnd@arndb•de>, Arnd Bergmann <arnd@kernel•org>
Cc: Nathan Chancellor <nathan@kernel•org>,
Anders Roxell <anders.roxell@linaro•org>,
Kees Cook <keescook@chromium•org>, Baoquan He <bhe@redhat•com>,
Niklas Schnelle <schnelle@linux•ibm.com>,
Naresh Kamboju <naresh.kamboju@linaro•org>,
clang-built-linux <llvm@lists•linux.dev>,
Nick Desaulniers <ndesaulniers@google•com>,
linux-kernel@vger•kernel.org, Nicholas Piggin <npiggin@gmail•com>,
"Aneesh Kumar K . V" <aneesh.kumar@kernel•org>,
Jeff Xu <jeffxu@chromium•org>, Mike Rapoport <rppt@kernel•org>,
Justin Stitt <justinstitt@google•com>,
"Naveen N. Rao" <naveen.n.rao@linux•ibm.com>,
linuxppc-dev <linuxppc-dev@lists•ozlabs.org>,
Dan Carpenter <dan.carpenter@linaro•org>,
Bill Wendling <morbo@google•com>
Subject: Re: [PATCH] powerpc: drop port I/O helpers for CONFIG_HAS_IOPORT=n
Date: Thu, 18 Apr 2024 23:01:25 +1000 [thread overview]
Message-ID: <8734ribza2.fsf@mail.lhotse> (raw)
In-Reply-To: <59473eb6-1707-4bbf-85a3-ba4835f3ee7f@app.fastmail.com>
"Arnd Bergmann" <arnd@arndb•de> writes:
> On Thu, Apr 18, 2024, at 08:26, Michael Ellerman wrote:
>> Arnd Bergmann <arnd@kernel•org> writes:
>
>> @@ -692,6 +692,7 @@ static inline void name at
>> \
>> #define writesw writesw
>> #define writesl writesl
>>
>> +#ifdef CONFIG_HAS_IOPORT
>> #define inb inb
>> #define inw inw
>> #define inl inl
>> @@ -704,6 +705,8 @@ static inline void name at
>> \
>> #define outsb outsb
>> #define outsw outsw
>> #define outsl outsl
>> +#endif // CONFIG_HAS_IOPORT
>> +
>> #ifdef __powerpc64__
>> #define readq readq
>> #define writeq writeq
>
> I had included this at first, but then I still ran into
> the same warnings because it ends up pulling in the
> generic outsb() etc from include/asm-generic/io.h
> that relies on setting a non-NULL PCI_IOBASE.
Yes you're right. The above fixes the gcc build, but not clang.
So I think I'll just cherry pick f0a816fb12da ("/dev/port: don't compile
file operations without CONFIG_DEVPORT") into my next and then apply
this. But will see if there's any other build failures over night.
cheers
next prev parent reply other threads:[~2024-04-18 13:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 15:33 [PATCH] powerpc: drop port I/O helpers for CONFIG_HAS_IOPORT=n Arnd Bergmann
2024-04-18 6:26 ` Michael Ellerman
2024-04-18 6:33 ` Michael Ellerman
2024-04-18 6:59 ` Arnd Bergmann
2024-04-18 13:01 ` Michael Ellerman [this message]
2024-04-19 5:12 ` Michael Ellerman
2024-04-19 5:58 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734ribza2.fsf@mail.lhotse \
--to=mpe@ellerman$(echo .)id.au \
--cc=anders.roxell@linaro$(echo .)org \
--cc=aneesh.kumar@kernel$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=arnd@kernel$(echo .)org \
--cc=bhe@redhat$(echo .)com \
--cc=dan.carpenter@linaro$(echo .)org \
--cc=jeffxu@chromium$(echo .)org \
--cc=justinstitt@google$(echo .)com \
--cc=keescook@chromium$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=llvm@lists$(echo .)linux.dev \
--cc=morbo@google$(echo .)com \
--cc=naresh.kamboju@linaro$(echo .)org \
--cc=nathan@kernel$(echo .)org \
--cc=naveen.n.rao@linux$(echo .)ibm.com \
--cc=ndesaulniers@google$(echo .)com \
--cc=npiggin@gmail$(echo .)com \
--cc=rppt@kernel$(echo .)org \
--cc=schnelle@linux$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox