From: Michael Ellerman <mpe@ellerman•id.au>
To: Nicolin Chen <nicoleotsuka@gmail•com>, hch@lst•de
Cc: x86@kernel•org, linux-ia64@vger•kernel.org,
James.Bottomley@HansenPartnership•com, paulus@samba•org,
hpa@zytor•com, sparclinux@vger•kernel.org, sfr@canb•auug.org.au,
deller@gmx•de, schnelle@linux•ibm.com, borntraeger@de•ibm.com,
mingo@redhat•com, mattst88@gmail•com, fenghua.yu@intel•com,
gor@linux•ibm.com, linux-s390@vger•kernel.org, hca@linux•ibm.com,
ink@jurassic•park.msu.ru, tglx@linutronix•de,
gerald.schaefer@linux•ibm.com, rth@twiddle•net,
tony.luck@intel•com, linux-parisc@vger•kernel.org,
linux-kernel@vger•kernel.org, linux-alpha@vger•kernel.org,
bp@alien8•de, linuxppc-dev@lists•ozlabs.org, davem@davemloft•net
Subject: Re: [PATCH 1/2] dma-mapping: introduce dma_get_seg_boundary_nr_pages()
Date: Thu, 03 Sep 2020 13:47:43 +1000 [thread overview]
Message-ID: <87363z1py8.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <20200901221646.26491-2-nicoleotsuka@gmail.com>
Nicolin Chen <nicoleotsuka@gmail•com> writes:
> diff --git a/arch/powerpc/kernel/iommu.c b/arch/powerpc/kernel/iommu.c
> index 9704f3f76e63..cbc2e62db597 100644
> --- a/arch/powerpc/kernel/iommu.c
> +++ b/arch/powerpc/kernel/iommu.c
> @@ -236,15 +236,10 @@ static unsigned long iommu_range_alloc(struct device *dev,
> }
> }
>
> - if (dev)
> - boundary_size = ALIGN(dma_get_seg_boundary(dev) + 1,
> - 1 << tbl->it_page_shift);
> - else
> - boundary_size = ALIGN(1UL << 32, 1 << tbl->it_page_shift);
> - /* 4GB boundary for iseries_hv_alloc and iseries_hv_map */
> + boundary_size = dma_get_seg_boundary_nr_pages(dev, tbl->it_page_shift);
>
> n = iommu_area_alloc(tbl->it_map, limit, start, npages, tbl->it_offset,
> - boundary_size >> tbl->it_page_shift, align_mask);
> + boundary_size, align_mask);
This has changed the units of boundary_size, but it's unused elsewhere
in the function so that's OK.
If you need to do a v2 for any other reason, then I'd just drop
boundary_size and call dma_get_seg_boundary_nr_pages() directly in the
function call.
Acked-by: Michael Ellerman <mpe@ellerman•id.au> (powerpc)
cheers
next prev parent reply other threads:[~2020-09-03 3:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 22:16 [PATCH 0/2] dma-mapping: update default segment_boundary_mask Nicolin Chen
2020-09-01 22:16 ` [PATCH 1/2] dma-mapping: introduce dma_get_seg_boundary_nr_pages() Nicolin Chen
2020-09-03 3:47 ` Michael Ellerman [this message]
2020-09-03 10:57 ` Andy Shevchenko
2020-09-03 16:12 ` Christoph Hellwig
2020-09-03 17:53 ` Christophe Leroy
2020-09-01 22:16 ` [PATCH 2/2] dma-mapping: set default segment_boundary_mask to ULONG_MAX Nicolin Chen
2020-09-02 8:13 ` [PATCH 0/2] dma-mapping: update default segment_boundary_mask Niklas Schnelle
2020-09-03 3:26 ` Nicolin Chen
2020-09-03 16:13 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87363z1py8.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=James.Bottomley@HansenPartnership$(echo .)com \
--cc=borntraeger@de$(echo .)ibm.com \
--cc=bp@alien8$(echo .)de \
--cc=davem@davemloft$(echo .)net \
--cc=deller@gmx$(echo .)de \
--cc=fenghua.yu@intel$(echo .)com \
--cc=gerald.schaefer@linux$(echo .)ibm.com \
--cc=gor@linux$(echo .)ibm.com \
--cc=hca@linux$(echo .)ibm.com \
--cc=hch@lst$(echo .)de \
--cc=hpa@zytor$(echo .)com \
--cc=ink@jurassic$(echo .)park.msu.ru \
--cc=linux-alpha@vger$(echo .)kernel.org \
--cc=linux-ia64@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-parisc@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mattst88@gmail$(echo .)com \
--cc=mingo@redhat$(echo .)com \
--cc=nicoleotsuka@gmail$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=rth@twiddle$(echo .)net \
--cc=schnelle@linux$(echo .)ibm.com \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=tglx@linutronix$(echo .)de \
--cc=tony.luck@intel$(echo .)com \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox