From: Daniel Axtens <dja@axtens•net>
To: Christophe Leroy <christophe.leroy@c-s•fr>,
Joel Stanley <joel@jms•id.au>,
linuxppc-dev@lists•ozlabs.org
Cc: Nick Desaulniers <ndesaulniers@google•com>
Subject: Re: [PATCH] powerpc/vdso32: Drop -mabi=elfv1 for 32 bit objects
Date: Fri, 11 Jan 2019 01:45:23 +1100 [thread overview]
Message-ID: <8736q0po58.fsf@linkitivity.dja.id.au> (raw)
In-Reply-To: <82aeb9f8-6d25-de79-487c-a073ea33ba69@c-s.fr>
Christophe Leroy <christophe.leroy@c-s•fr> writes:
> Le 10/01/2019 à 02:42, Joel Stanley a écrit :
>> From: Daniel Axtens <dja@axtens•net>
>>
>> All 64-bit objects need to specify the flag to be compiled correctly, we
>> just don't need it for 32-bit objects. GCC just ignored it, but clang
>> doesn't.
>>
>> Link: https://github.com/ClangBuiltLinux/linux/issues/240
>> Signed-off-by: Daniel Axtens <dja@axtens•net>
>> Signed-off-by: Joel Stanley <joel@jms•id.au>
>> ---
>> arch/powerpc/kernel/vdso32/Makefile | 14 ++++++++++++++
>> 1 file changed, 14 insertions(+)
>>
>> diff --git a/arch/powerpc/kernel/vdso32/Makefile b/arch/powerpc/kernel/vdso32/Makefile
>> index 50112d4473bb..6bd41756e0c7 100644
>> --- a/arch/powerpc/kernel/vdso32/Makefile
>> +++ b/arch/powerpc/kernel/vdso32/Makefile
>> @@ -34,6 +34,20 @@ obj-y += vdso32_wrapper.o
>> extra-y += vdso32.lds
>> CPPFLAGS_vdso32.lds += -P -C -Upowerpc
>>
>> +# clang refuses to accept -mabi=elfv1 for when using the
>> +# 64-bit target in 32-bit mode
>> +ifdef CONFIG_CC_IS_CLANG
>
> If -mabi=elfv1 is unneeded even for GCC, why depend on CLANG ?
>
>> +ifdef CONFIG_PPC64
>> +AFLAGS_REMOVE_getcpu.o += -mabi=elfv1
>> +endif
>
> Why only this one is inside the ifdef ? powerpc Makefile only set
> -mabi=elfv1 when CONFIG_PPC64 is set, so all objects should be handled
> the same way.
>
> And would it harm just doing it all the time, regardless of CONFIG_PPC64 ?
I designed the patch to mirror some code earlier on, and to be
conservative in what it did. I have no issue with it being restructured,
but I probably won't have the time to do it for a month or so. I'm very
happy for you or Joel to rework it and to test any resulting patches.
Regards,
Daniel
>
> Christophe
>
>> +AFLAGS_REMOVE_sigtramp.o += -mabi=elfv1
>> +AFLAGS_REMOVE_gettimeofday.o += -mabi=elfv1
>> +AFLAGS_REMOVE_datapage.o += -mabi=elfv1
>> +AFLAGS_REMOVE_cacheflush.o += -mabi=elfv1
>> +AFLAGS_REMOVE_note.o += -mabi=elfv1
>> +endif
>> +
>> +
>> # Force dependency (incbin is bad)
>> $(obj)/vdso32_wrapper.o : $(obj)/vdso32.so
>>
>>
next prev parent reply other threads:[~2019-01-10 14:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 1:42 [PATCH] powerpc/vdso32: Drop -mabi=elfv1 for 32 bit objects Joel Stanley
2019-01-10 7:10 ` Christophe Leroy
2019-01-10 14:45 ` Daniel Axtens [this message]
2019-01-10 15:28 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736q0po58.fsf@linkitivity.dja.id.au \
--to=dja@axtens$(echo .)net \
--cc=christophe.leroy@c-s$(echo .)fr \
--cc=joel@jms$(echo .)id.au \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=ndesaulniers@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox