From: Michael Ellerman <mpe@ellerman•id.au>
To: "Guenter Roeck" <linux@roeck-us•net>, "Pali Rohár" <pali@kernel•org>
Cc: Tyrel Datwyler <tyreld@linux•ibm.com>,
Guowen Shan <gshan@redhat•com>,
linux-kernel@vger•kernel.org,
"Guilherme G. Piccoli" <gpiccoli@igalia•com>,
Bjorn Helgaas <helgaas@kernel•org>,
linux-pci@vger•kernel.org, Paul Mackerras <paulus@samba•org>,
linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH v2 2/2] powerpc/pci: Prefer PCI domain assignment via DT 'linux,pci-domain' and alias
Date: Mon, 15 Aug 2022 15:46:31 +1000 [thread overview]
Message-ID: <874jyevz2g.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <20220813135735.GA3413265@roeck-us.net>
Guenter Roeck <linux@roeck-us•net> writes:
> On Wed, Jul 06, 2022 at 12:21:48PM +0200, Pali Rohár wrote:
>> Other Linux architectures use DT property 'linux,pci-domain' for specifying
>> fixed PCI domain of PCI controller specified in Device-Tree.
>>
>> And lot of Freescale powerpc boards have defined numbered pci alias in
>> Device-Tree for every PCIe controller which number specify preferred PCI
>> domain.
>>
>> So prefer usage of DT property 'linux,pci-domain' (via function
>> of_get_pci_domain_nr()) and DT pci alias (via function of_alias_get_id())
>> on powerpc architecture for assigning PCI domain to PCI controller.
>>
>> Fixes: 63a72284b159 ("powerpc/pci: Assign fixed PHB number based on device-tree properties")
>> Signed-off-by: Pali Rohár <pali@kernel•org>
>
> This patch results in a number of boot warnings with various qemu
> boot tests.
Thanks for the report.
I have automated qemu boot tests to catch things like this, they even
have DEBUG_ATOMIC_SLEEP enabled ... but I inadvertantly broke my script
that checks for "BUG:" in the console log. Sometimes you just can't
win.
cheers
next prev parent reply other threads:[~2022-08-15 5:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-06 10:21 [PATCH v2 1/2] powerpc/pci: Add config option for using OF 'reg' for PCI domain Pali Rohár
2022-07-06 10:21 ` [PATCH v2 2/2] powerpc/pci: Prefer PCI domain assignment via DT 'linux,pci-domain' and alias Pali Rohár
2022-08-13 13:57 ` Guenter Roeck
2022-08-15 5:46 ` Michael Ellerman [this message]
2022-09-23 3:21 ` Benjamin Herrenschmidt
2022-07-15 14:55 ` [PATCH v2 1/2] powerpc/pci: Add config option for using OF 'reg' for PCI domain Guilherme G. Piccoli
2022-07-15 17:11 ` Pali Rohár
2022-07-15 18:32 ` Guilherme G. Piccoli
2022-07-16 11:35 ` Pali Rohár
2022-07-27 12:33 ` Michael Ellerman
2022-07-29 13:02 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jyevz2g.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=gpiccoli@igalia$(echo .)com \
--cc=gshan@redhat$(echo .)com \
--cc=helgaas@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linux@roeck-us$(echo .)net \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=pali@kernel$(echo .)org \
--cc=paulus@samba$(echo .)org \
--cc=tyreld@linux$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox