From: Peter Korsgaard <jacmet@sunsite•dk>
To: Ricardo Ribalda Delgado <ricardo.ribalda@uam•es>
Cc: linuxppc-dev@ozlabs•org, David.Woodhouse@intel•com,
linuxppc-embedded@ozlabs•org
Subject: Re: [MTD] ofpart: Partitions at same address cannot have the same name
Date: Wed, 22 Apr 2009 11:24:01 +0200 [thread overview]
Message-ID: <874owhoxce.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <1240387541-16594-1-git-send-email-ricardo.ribalda@uam.es> (Ricardo Ribalda Delgado's message of "Wed\, 22 Apr 2009 10\:05\:41 +0200")
>>>>> "Ricardo" == Ricardo Ribalda Delgado <ricardo.ribalda@uam•es> writes:
Hi,
Ricardo> Sometimes, an special partition is included in the device
Ricardo> tree including all the partitions. Like in:
Ricardo> drivers/mtd/ofpart.c | 3 ++-
Ricardo> 1 files changed, 2 insertions(+), 1 deletions(-)
Ricardo> diff --git a/drivers/mtd/ofpart.c b/drivers/mtd/ofpart.c
Ricardo> index 3e164f0..0af3b07 100644
Ricardo> --- a/drivers/mtd/ofpart.c
Ricardo> +++ b/drivers/mtd/ofpart.c
Ricardo> @@ -48,7 +48,8 @@ int __devinit of_mtd_parse_partitions(struct device *dev,
Ricardo> /* check if this is a partition node */
Ricardo> partname = of_get_property(pp, "name", &len);
Ricardo> - if (strcmp(partname, "partition") != 0) {
Ricardo> + if (strncmp(partname, "partition", strlen("partition")-1)
Why strlen() - 1 ?
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2009-04-22 9:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-22 8:05 [MTD] ofpart: Partitions at same address cannot have the same name Ricardo Ribalda Delgado
2009-04-22 9:24 ` Peter Korsgaard [this message]
2009-04-22 15:34 ` Ricardo Ribalda Delgado
2009-04-22 15:52 ` Ricardo Ribalda Delgado
2009-04-22 17:10 ` Benjamin Krill
2009-04-22 17:27 ` Scott Wood
2009-04-22 17:56 ` Ricardo Ribalda Delgado
2009-04-22 18:11 ` Scott Wood
2009-04-22 18:58 ` Ricardo Ribalda Delgado
2009-04-22 17:59 ` Ricardo Ribalda Delgado
2009-04-22 18:33 ` Benjamin Krill
2009-04-30 3:19 ` [MTD] " Benjamin Herrenschmidt
2009-04-30 5:32 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874owhoxce.fsf@macbook.be.48ers.dk \
--to=jacmet@sunsite$(echo .)dk \
--cc=David.Woodhouse@intel$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=linuxppc-embedded@ozlabs$(echo .)org \
--cc=ricardo.ribalda@uam$(echo .)es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox