Subject: Re: [PATCH] fsl_spi_init: Support non-QE processors

From: Peter Korsgaard <[email-masked]>
Date: Wed, 03 Oct 2007 18:04:50 +0200

>>>>> "Grant" == Grant Likely <[email-masked]> writes:

Hi,

 Grant> Why not just:

 Grant>         np = of_find_node_by_type(NULL, "qe");
 Grant> +       if (!np)
 Grant> +               np = of_find_node_by_type(NULL, "soc");
 Grant>         if (!np)
 Grant>                 return -ENODEV;

My first iteration did it like that, but then you don't get a -ENODEV
if the node is missing (and you'll end up using the wrong clock) and
it doesn't support processors with SPI on and off QE (if that
exists/will ever exist).

-- 
Bye, Peter Korsgaard