From: John Ogness <john.ogness@linutronix•de>
To: Petr Mladek <pmladek@suse•com>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail•com>,
Alexey Kardashevskiy <aik@ozlabs•ru>,
Paul Mackerras <paulus@samba•org>,
Tiezhu Yang <yangtiezhu@loongson•cn>,
Rafael Aquini <aquini@redhat•com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux•ibm.com>,
Peter Zijlstra <peterz@infradead•org>, Yue Hu <huyue2@yulong•com>,
Jordan Niethe <jniethe5@gmail•com>,
Kees Cook <keescook@chromium•org>,
"Paul E. McKenney" <paulmck@kernel•org>,
Alistair Popple <alistair@popple•id.au>,
"Guilherme G. Piccoli" <gpiccoli@canonical•com>,
Nicholas Piggin <npiggin@gmail•com>,
Steven Rostedt <rostedt@goodmis•org>,
Thomas Gleixner <tglx@linutronix•de>,
kexec@lists•infradead.org, linux-kernel@vger•kernel.org,
Sergey Senozhatsky <sergey.senozhatsky@gmail•com>,
Eric Biederman <ebiederm@xmission•com>,
Andrew Morton <akpm@linux-foundation•org>,
linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH printk v2 2/5] printk: remove safe buffers
Date: Wed, 31 Mar 2021 09:59:39 +0200 [thread overview]
Message-ID: <875z17vjmc.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <20210330153512.1182-3-john.ogness@linutronix.de>
On 2021-03-30, John Ogness <john.ogness@linutronix•de> wrote:
> diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
> index e971c0a9ec9e..f090d6a1b39e 100644
> --- a/kernel/printk/printk.c
> +++ b/kernel/printk/printk.c
> @@ -1772,16 +1759,21 @@ static struct task_struct *console_owner;
> static bool console_waiter;
>
> /**
> - * console_lock_spinning_enable - mark beginning of code where another
> + * console_lock_spinning_enable_irqsave - mark beginning of code where another
> * thread might safely busy wait
> *
> * This basically converts console_lock into a spinlock. This marks
> * the section where the console_lock owner can not sleep, because
> * there may be a waiter spinning (like a spinlock). Also it must be
> * ready to hand over the lock at the end of the section.
> + *
> + * This disables interrupts because the hand over to a waiter must not be
> + * interrupted until the hand over is completed (@console_waiter is cleared).
> */
> -static void console_lock_spinning_enable(void)
> +static void console_lock_spinning_enable_irqsave(unsigned long *flags)
I missed the prototype change for the !CONFIG_PRINTK case, resulting in:
linux/kernel/printk/printk.c:2707:3: error: implicit declaration of function ‘console_lock_spinning_enable_irqsave’; did you mean ‘console_lock_spinning_enable’? [-Werror=implicit-function-declaration]
console_lock_spinning_enable_irqsave(&flags);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
console_lock_spinning_enable
Will be fixed for v3.
(I have now officially added !CONFIG_PRINTK to my CI tests.)
John Ogness
next prev parent reply other threads:[~2021-03-31 8:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 15:35 [PATCH printk v2 0/5] printk: remove safe buffers John Ogness
2021-03-30 15:35 ` [PATCH printk v2 2/5] " John Ogness
2021-03-31 7:59 ` John Ogness [this message]
2021-04-01 12:21 ` Petr Mladek
2021-04-01 13:19 ` John Ogness
2021-04-01 14:17 ` Petr Mladek
2021-04-02 2:14 ` Sergey Senozhatsky
2021-04-06 11:17 ` Petr Mladek
2021-04-06 11:01 ` John Ogness
2021-03-30 15:35 ` [PATCH printk v2 3/5] printk: remove NMI tracking John Ogness
2021-04-01 14:37 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875z17vjmc.fsf@jogness.linutronix.de \
--to=john.ogness@linutronix$(echo .)de \
--cc=aik@ozlabs$(echo .)ru \
--cc=akpm@linux-foundation$(echo .)org \
--cc=alistair@popple$(echo .)id.au \
--cc=aneesh.kumar@linux$(echo .)ibm.com \
--cc=aquini@redhat$(echo .)com \
--cc=ebiederm@xmission$(echo .)com \
--cc=gpiccoli@canonical$(echo .)com \
--cc=huyue2@yulong$(echo .)com \
--cc=jniethe5@gmail$(echo .)com \
--cc=keescook@chromium$(echo .)org \
--cc=kexec@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=npiggin@gmail$(echo .)com \
--cc=paulmck@kernel$(echo .)org \
--cc=paulus@samba$(echo .)org \
--cc=peterz@infradead$(echo .)org \
--cc=pmladek@suse$(echo .)com \
--cc=rostedt@goodmis$(echo .)org \
--cc=sergey.senozhatsky.work@gmail$(echo .)com \
--cc=sergey.senozhatsky@gmail$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=yangtiezhu@loongson$(echo .)cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox