From: Michael Ellerman <mpe@ellerman•id.au>
To: Daniel Axtens <dja@axtens•net>,
linux-pci@vger•kernel.org, linuxppc-dev@lists•ozlabs.org,
linux-arm-kernel@lists•infradead.org
Cc: gabriele.paoloni@huawei•com, airlied@linux•ie,
Brian King <brking@linux•vnet.ibm.com>,
will.deacon@arm•com, z.liuxinliang@hisilicon•com,
bhelgaas@google•com, alex.williamson@redhat•com,
catalin.marinas@arm•com, zourongrong@gmail•com,
daniel.vetter@intel•com
Subject: Re: [PATCH 3/3] powerpc: replace vga_fixup() with generic code
Date: Tue, 08 Aug 2017 20:12:55 +1000 [thread overview]
Message-ID: <8760dynza0.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <87wp6fq8y5.fsf@linkitivity.dja.id.au>
Daniel Axtens <dja@axtens•net> writes:
> Michael Ellerman <mpe@ellerman•id.au> writes:
>
>> Daniel Axtens <dja@axtens•net> writes:
>>
>>> Currently, we do a PCI fixup to mark a default card so that Xorg
>>> autoconfiguration works.
>>>
>>> There is a new generic method to do this sort of vga fixup, and
>>> it occurs by default.
>>>
>>> Drop our old method.
>>>
>>> This method is different:
>>> - it will only mark a card as default if a driver is bound
>>> - the marking will happen at late_initcall time, or even later
>>> if a card is enabled later on (via an ENABLE hook). Currently
>>> things are enabled in a FINAL hook.
>>>
>>> This *does* change behaviour under some circumstances.
>>>
>>> For example, pseries_le_defconfig doesn't have DRM drivers for
>>> many of the qemu GPU models, including the 'standard' vga.
>>
>> Should we enable them/it?
>
> Hard to say.
>
> The 'standard' vga module (bochs_drm) was blacklisted by Ubuntu -
> apparently at IBM's request [0] - some years back. Even if you
> un-blacklist it, I had trouble with getting it and the openfirmware
> framebuffer driver to play nicely together. It may not be worth the
> trouble for bochs_drm.
>
> There's a better case for including some of the more modern drivers -
> maybe QXL and virtio - but I wasn't able to test them: my particular
> build of qemu/TCG refused to start with them and I didn't feel like
> rebuilding/debugging qemu.
Yeah OK. Sounds like a bit of mess :)
I'll leave it unless someone who knows Qemu/Gfx etc. tells me otherwise.
> It would also be legitmate to say that you're focussing on headless use
> with pseries_*defconfig and not include them: you need to bring in the
> DRM core if you want these drivers.
True. There's a bit of a tension there between making them useful
configs for developers and also turning on as much code as possible so
it gets tested.
Arguably we should have DRM enabled because the distros will.
cheers
prev parent reply other threads:[~2017-08-08 10:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-04 10:20 [PATCH 0/3] Split VGA default selection from VGA arbiter Daniel Axtens
2017-08-04 10:20 ` [PATCH 1/3] powerpc: simplify and fix VGA default device behaviour Daniel Axtens
2017-08-11 21:44 ` Bjorn Helgaas
2017-08-13 22:34 ` Daniel Axtens
2017-08-04 10:20 ` [PATCH 2/3] Split VGA default device handler out of VGA arbiter Daniel Axtens
2017-08-05 6:57 ` Lukas Wunner
2017-08-06 23:49 ` Daniel Axtens
2017-08-04 10:20 ` [PATCH 3/3] powerpc: replace vga_fixup() with generic code Daniel Axtens
2017-08-07 7:18 ` Michael Ellerman
2017-08-07 23:01 ` Daniel Axtens
2017-08-08 10:12 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760dynza0.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=airlied@linux$(echo .)ie \
--cc=alex.williamson@redhat$(echo .)com \
--cc=bhelgaas@google$(echo .)com \
--cc=brking@linux$(echo .)vnet.ibm.com \
--cc=catalin.marinas@arm$(echo .)com \
--cc=daniel.vetter@intel$(echo .)com \
--cc=dja@axtens$(echo .)net \
--cc=gabriele.paoloni@huawei$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=will.deacon@arm$(echo .)com \
--cc=z.liuxinliang@hisilicon$(echo .)com \
--cc=zourongrong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox