Subject: Re: [PATCH] powerpc/mm/hash: Clear the invalid slot information correctly

From: "Aneesh Kumar K.V" <[email-masked]>
Date: Sat, 20 Feb 2016 20:02:58 +0530

Michael Ellerman <[email-masked]> writes:

> On Fri, 2016-02-19 at 11:23 +0530, Anshuman Khandual wrote:
>> On 02/18/2016 10:14 PM, Aneesh Kumar K.V wrote:
>> > We can get a hash pte fault with 4k base page size and find the pte
>> > already inserted with 64K base page size. In that case we need to clear
> ...
>>
>> > diff --git a/arch/powerpc/mm/hash64_4k.c b/arch/powerpc/mm/hash64_4k.c
>> > index e7c04542ba62..e3e76b929f33 100644
>> > --- a/arch/powerpc/mm/hash64_4k.c
>> > +++ b/arch/powerpc/mm/hash64_4k.c
>> > @@ -106,7 +106,7 @@ repeat:
>> >  			}
>> >  		}
>> >  		/*
>> > -		 * Hypervisor failure. Restore old pmd and return -1
>> > +		 * Hypervisor failure. Restore old pte and return -1
>>
>> This change is not relevant here. Should be a separate patch.
>
> Yeah.
>
> If it was -rc1 then I would probably let it go, but this will land in rc6 so
> the fixes need to be tight.
>

You want me to do an upate with those changes dropped ?.

-aneesh