Subject: Re: [PATCH 6/6] [C67x00] Merge c67x00-hub.c into c67x00-hcd.c

From: Peter Korsgaard <[email-masked]>
Date: Wed, 13 Jun 2007 07:58:31 +0200

>>>>> "Grant" == Grant Likely <[email-masked]> writes:

Hi,

 Grant> Rather than c67x00-hub.c being compiled seperately, the
 Grant> original code had c67x00-hub.c *included* by c67x00-hcd.c.
 Grant> This is a very bad idea.  Simplest solution is to merge the
 Grant> two files into one and be done with it.

Yeah, it isn't exactly pretty, but it's what the other hcd drivers do,
E.G.:

% grep -rs "include.*hub.c" *c 
ehci-hcd.c:#include "ehci-hub.c"
ohci-hcd.c:#include "ohci-hub.c"
uhci-hcd.c:#include "uhci-hub.c"

I don't quite know why they do it like that though ..

-- 
Bye, Peter Korsgaard