From: Michael Ellerman <mpe@ellerman•id.au>
To: Segher Boessenkool <segher@kernel•crashing.org>
Cc: linuxppc-dev@ozlabs•org, chandan@linux•ibm.com
Subject: Re: [PATCH v3] powerpc/64: Fix memcmp reading past the end of src/dest
Date: Mon, 25 Mar 2019 23:33:56 +1100 [thread overview]
Message-ID: <877ecnp1zf.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20190322182943.GF3969@gate.crashing.org>
Segher Boessenkool <segher@kernel•crashing.org> writes:
> On Fri, Mar 22, 2019 at 11:37:24PM +1100, Michael Ellerman wrote:
>> .Lcmp_rest_lt8bytes:
>> - /* Here we have only less than 8 bytes to compare with. at least s1
>> - * Address is aligned with 8 bytes.
>> - * The next double words are load and shift right with appropriate
>> - * bits.
>> + /*
>> + * Here we have less than 8 bytes to compare. At least s1 is aligned to
>> + * 8 bytes, but s2 may not be. We must make sure s2 + 8 doesn't cross a
>
> "s2 + 7"? The code is fine though (bgt, not bge).
Duh, thanks for catching it.
>> + * page boundary, otherwise we might read past the end of the buffer and
>> + * trigger a page fault. We use 4K as the conservative minimum page
>> + * size. If we detect that case we go to the byte-by-byte loop.
>> + *
>> + * Otherwise the next double word is loaded from s1 and s2, and shifted
>> + * right to compare the appropriate bits.
>> */
>> + clrldi r6,r4,(64-12) // r6 = r4 & 0xfff
>
> You can just write
> rlwinm r6,r4,0,0x0fff
> if that is clearer? Or do you still want a comment with that :-)
I don't think it's clearer doing a rotate of zero bits :)
And yeah I'd probably still leave the comment, so I'm inclined to stick
with the clrldi?
Would be nice if the assembler could support:
andi r6, r4, 0x0fff
And turn it into the rlwinm, or rldicl :)
>> + cmpdi r6,0xff8
>> + bgt .Lshort
>
> Reviewed-by: Segher Boessenkool <segher@kernel•crashing.org>
I'll fixup the comment. Thanks.
cheers
next prev parent reply other threads:[~2019-03-25 12:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 12:37 [PATCH v3] powerpc/64: Fix memcmp reading past the end of src/dest Michael Ellerman
2019-03-22 18:29 ` Segher Boessenkool
2019-03-25 12:33 ` Michael Ellerman [this message]
2019-03-25 17:54 ` Segher Boessenkool
2019-03-26 9:18 ` Michael Ellerman
2019-03-26 18:39 ` Segher Boessenkool
2019-03-25 6:38 ` Chandan Rajendra
2019-03-25 6:39 ` Chandan Rajendra
2019-03-31 10:13 ` [v3] " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877ecnp1zf.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=chandan@linux$(echo .)ibm.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=segher@kernel$(echo .)crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox