From: Vaibhav Jain <vaibhav@linux•vnet.ibm.com>
To: Michal Suchanek <msuchanek@suse•de>,
Benjamin Herrenschmidt <benh@kernel•crashing.org>,
Paul Mackerras <paulus@samba•org>,
Michael Ellerman <mpe@ellerman•id.au>,
Balbir Singh <bsingharora@gmail•com>,
Nicholas Piggin <npiggin@gmail•com>,
Breno Leitao <leitao@debian•org>,
"Guilherme G. Piccoli" <gpiccoli@linux•vnet.ibm.com>,
Michal Suchanek <msuchanek@suse•de>,
linuxppc-dev@lists•ozlabs.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH v2] powerpc/xmon: Also setup debugger hooks when single-stepping
Date: Wed, 23 May 2018 23:51:45 +0530 [thread overview]
Message-ID: <877enuxmfa.fsf@vajain21.in.ibm.com> (raw)
In-Reply-To: <20180523180054.9937-1-msuchanek@suse.de>
Michal Suchanek <msuchanek@suse•de> writes:
> When single-stepping kernel code from xmon without a debug hook enabled
> the kernel crashes. This can happen when kernel starts with xmon on
> crash disabled but xmon is entered using sysrq.
>
> Call force_enable_xmon when single-stepping in xmon to install the xmon
> debug hooks.
>
> Fixes: e1368d0c9edb ("powerpc/xmon: Setup debugger hooks when first
> break-point is set")
>
> Signed-off-by: Michal Suchanek <msuchanek@suse•de>
> ---
LGTM,
Reviewed-by: Vaibhav Jain <vaibhav@linux•ibm.com>
--
Vaibhav Jain <vaibhav@linux•ibm.com>
Linux Technology Center, IBM India Pvt. Ltd.
next prev parent reply other threads:[~2018-05-23 18:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-23 18:00 [PATCH v2] powerpc/xmon: Also setup debugger hooks when single-stepping Michal Suchanek
2018-05-23 18:21 ` Vaibhav Jain [this message]
2018-05-25 11:41 ` [v2] " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877enuxmfa.fsf@vajain21.in.ibm.com \
--to=vaibhav@linux$(echo .)vnet.ibm.com \
--cc=benh@kernel$(echo .)crashing.org \
--cc=bsingharora@gmail$(echo .)com \
--cc=gpiccoli@linux$(echo .)vnet.ibm.com \
--cc=leitao@debian$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mpe@ellerman$(echo .)id.au \
--cc=msuchanek@suse$(echo .)de \
--cc=npiggin@gmail$(echo .)com \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox