From: "Aneesh Kumar K.V" <aneesh.kumar@linux•vnet.ibm.com>
To: Alistair Popple <alistair@popple•id.au>, mpe@ellerman•id.au
Cc: linuxppc-dev@ozlabs•org, shreyas@linux•vnet.ibm.com,
Alistair Popple <alistair@popple•id.au>
Subject: Re: [PATCH] opal-elog: Fix opal-elog interrupt handler
Date: Sat, 04 Jul 2015 12:04:00 +0530 [thread overview]
Message-ID: <877fqgsa7b.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <1435909152-18891-1-git-send-email-alistair@popple.id.au>
Alistair Popple <alistair@popple•id.au> writes:
> The conversion of opal events to a proper irqchip means that handlers
> are called until the relevant opal event has been cleared by
> processing it. Events that queue work should therefore use a threaded
> handler to mask the event until processing is complete.
>
> Signed-off-by: Alistair Popple <alistair@popple•id.au>
Tested-by: Aneesh Kumar K.V <aneesh.kumar@linux•vnet.ibm.com>
> ---
> arch/powerpc/platforms/powernv/opal-elog.c | 16 +++++-----------
> 1 file changed, 5 insertions(+), 11 deletions(-)
>
> diff --git a/arch/powerpc/platforms/powernv/opal-elog.c b/arch/powerpc/platforms/powernv/opal-elog.c
> index 4949ef0..37f959b 100644
> --- a/arch/powerpc/platforms/powernv/opal-elog.c
> +++ b/arch/powerpc/platforms/powernv/opal-elog.c
> @@ -237,7 +237,7 @@ static struct elog_obj *create_elog_obj(uint64_t id, size_t size, uint64_t type)
> return elog;
> }
>
> -static void elog_work_fn(struct work_struct *work)
> +static irqreturn_t elog_event(int irq, void *data)
> {
> __be64 size;
> __be64 id;
> @@ -251,7 +251,7 @@ static void elog_work_fn(struct work_struct *work)
> rc = opal_get_elog_size(&id, &size, &type);
> if (rc != OPAL_SUCCESS) {
> pr_err("ELOG: OPAL log info read failed\n");
> - return;
> + return IRQ_HANDLED;
> }
>
> elog_size = be64_to_cpu(size);
> @@ -270,16 +270,10 @@ static void elog_work_fn(struct work_struct *work)
> * entries.
> */
> if (kset_find_obj(elog_kset, name))
> - return;
> + return IRQ_HANDLED;
>
> create_elog_obj(log_id, elog_size, elog_type);
> -}
> -
> -static DECLARE_WORK(elog_work, elog_work_fn);
>
> -static irqreturn_t elog_event(int irq, void *data)
> -{
> - schedule_work(&elog_work);
> return IRQ_HANDLED;
> }
>
> @@ -304,8 +298,8 @@ int __init opal_elog_init(void)
> return irq;
> }
>
> - rc = request_irq(irq, elog_event,
> - IRQ_TYPE_LEVEL_HIGH, "opal-elog", NULL);
> + rc = request_threaded_irq(irq, NULL, elog_event,
> + IRQF_TRIGGER_HIGH | IRQF_ONESHOT, "opal-elog", NULL);
> if (rc) {
> pr_err("%s: Can't request OPAL event irq (%d)\n",
> __func__, rc);
> --
> 2.1.4
next prev parent reply other threads:[~2015-07-04 6:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-03 7:39 [PATCH] opal-elog: Fix opal-elog interrupt handler Alistair Popple
2015-07-04 6:34 ` Aneesh Kumar K.V [this message]
2015-07-07 10:38 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877fqgsa7b.fsf@linux.vnet.ibm.com \
--to=aneesh.kumar@linux$(echo .)vnet.ibm.com \
--cc=alistair@popple$(echo .)id.au \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=mpe@ellerman$(echo .)id.au \
--cc=shreyas@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox