From: Daniel Axtens <dja@axtens•net>
To: Sandipan Das <sandipan@linux•ibm.com>, mpe@ellerman•id.au
Cc: naveen.n.rao@linux•ibm.com, linuxppc-dev@lists•ozlabs.org,
paulus@samba•org, ravi.bangoria@linux•ibm.com
Subject: Re: [RFC PATCH 5/5] powerpc: sstep: Add selftests for addc[.] instruction
Date: Mon, 11 Feb 2019 12:00:52 +1100 [thread overview]
Message-ID: <878syn3zqz.fsf@dja-thinkpad.axtens.net> (raw)
In-Reply-To: <9460deae6525f983b6ab44e3e35c1bbbd79d3ef5.1549253769.git.sandipan@linux.ibm.com>
Hi Sandipan,
> + {
> + .descr = "RA = LONG_MIN | INT_MIN, RB = LONG_MIN | INT_MIN",
> + .instr = PPC_INST_ADDC | ___PPC_RT(20) | ___PPC_RA(21) | ___PPC_RB(22),
> + .regs =
> + {
> + .gpr[21] = LONG_MIN | (uint) INT_MIN,
> + .gpr[22] = LONG_MIN | (uint) INT_MIN,
> + }
> + }
I don't know what this bit pattern is supposed to represent - is it
supposed to be the smallest 32bit integer and the smallest 64bit
integer 8000000080000000 - so you test 32 and 64 bit overflow at the
same time?
For the series:
Tested-by: Daniel Axtens <dja@axtens•net> # Power8 LE
I notice the output is quite verbose, and doesn't include a line when it
starts:
[ 0.826181] Running code patching self-tests ...
[ 0.826607] Running feature fixup self-tests ...
[ 0.826615] nop : R0 = LONG_MAX [PASS]
[ 0.826617] add : RA = LONG_MIN, RB = LONG_MIN [PASS]
Maybe it would be good to include a line saying "Running single-step
emulation self-tests" and perhaps by default on printing when there is a
failure.
Finally, I think you might be able to squash patches 1 and 2 and patches
4 and 5, but that's just my personal preference.
Regards,
Daniel
next prev parent reply other threads:[~2019-02-11 1:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 4:18 [RFC PATCH 0/5] powerpc: sstep: Emulation test infrastructure Sandipan Das
2019-02-04 4:18 ` [RFC PATCH 1/5] powerpc: Add bitmasks for D-form instruction fields Sandipan Das
2019-02-04 4:18 ` [RFC PATCH 2/5] powerpc: Add bitmask for Rc instruction field Sandipan Das
2019-02-04 4:18 ` [RFC PATCH 3/5] powerpc: sstep: Add instruction emulation selftests Sandipan Das
2019-02-11 0:47 ` Daniel Axtens
2019-02-11 10:15 ` Sandipan Das
2019-02-04 4:18 ` [RFC PATCH 4/5] powerpc: sstep: Add selftests for add[.] instruction Sandipan Das
2019-02-04 4:18 ` [RFC PATCH 5/5] powerpc: sstep: Add selftests for addc[.] instruction Sandipan Das
2019-02-11 1:00 ` Daniel Axtens [this message]
2019-02-11 10:14 ` Sandipan Das
2019-02-11 1:01 ` [RFC PATCH 0/5] powerpc: sstep: Emulation test infrastructure Daniel Axtens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878syn3zqz.fsf@dja-thinkpad.axtens.net \
--to=dja@axtens$(echo .)net \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mpe@ellerman$(echo .)id.au \
--cc=naveen.n.rao@linux$(echo .)ibm.com \
--cc=paulus@samba$(echo .)org \
--cc=ravi.bangoria@linux$(echo .)ibm.com \
--cc=sandipan@linux$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox