Subject: Re: [PATCH 1/2] powerpc/powernv: Create separate subcores CPU feature bit

From: "Aneesh Kumar K.V" <[email-masked]>
Date: Wed, 17 Feb 2016 20:29:22 +0530

Michael Neuling <[email-masked]> writes:

> Subcores isn't really part of the 2.07 architecture but currently we
> turn it on using the 2.07 feature bit.  Subcores is really a POWER8
> specific feature.
>
> This adds a new CPU_FTR bit just for subcores and moves the subcore
> init code over to use this.
>

Reviewed-by: Aneesh Kumar K.V <[email-masked]>

> Signed-off-by: Michael Neuling <[email-masked]>
> ---
>  arch/powerpc/include/asm/cputable.h      | 3 ++-
>  arch/powerpc/platforms/powernv/subcore.c | 2 +-
>  2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/include/asm/cputable.h b/arch/powerpc/include/asm/cputable.h
> index b118072..a47e175 100644
> --- a/arch/powerpc/include/asm/cputable.h
> +++ b/arch/powerpc/include/asm/cputable.h
> @@ -196,6 +196,7 @@ enum {
>  #define CPU_FTR_DAWR			LONG_ASM_CONST(0x0400000000000000)
>  #define CPU_FTR_DABRX			LONG_ASM_CONST(0x0800000000000000)
>  #define CPU_FTR_PMAO_BUG		LONG_ASM_CONST(0x1000000000000000)
> +#define CPU_FTR_SUBCORE			LONG_ASM_CONST(0x2000000000000000)
>
>  #ifndef __ASSEMBLY__
>
> @@ -443,7 +444,7 @@ enum {
>  	    CPU_FTR_STCX_CHECKS_ADDRESS | CPU_FTR_POPCNTB | CPU_FTR_POPCNTD | \
>  	    CPU_FTR_ICSWX | CPU_FTR_CFAR | CPU_FTR_HVMODE | CPU_FTR_VMX_COPY | \
>  	    CPU_FTR_DBELL | CPU_FTR_HAS_PPR | CPU_FTR_DAWR | \
> -	    CPU_FTR_ARCH_207S | CPU_FTR_TM_COMP)
> +	    CPU_FTR_ARCH_207S | CPU_FTR_TM_COMP | CPU_FTR_SUBCORE)
>  #define CPU_FTRS_POWER8E (CPU_FTRS_POWER8 | CPU_FTR_PMAO_BUG)
>  #define CPU_FTRS_POWER8_DD1 (CPU_FTRS_POWER8 & ~CPU_FTR_DBELL)
>  #define CPU_FTRS_CELL	(CPU_FTR_USE_TB | CPU_FTR_LWSYNC | \
> diff --git a/arch/powerpc/platforms/powernv/subcore.c b/arch/powerpc/platforms/powernv/subcore.c
> index 503a73f..0babef1 100644
> --- a/arch/powerpc/platforms/powernv/subcore.c
> +++ b/arch/powerpc/platforms/powernv/subcore.c
> @@ -407,7 +407,7 @@ static DEVICE_ATTR(subcores_per_core, 0644,
>
>  static int subcore_init(void)
>  {
> -	if (!cpu_has_feature(CPU_FTR_ARCH_207S))
> +	if (!cpu_has_feature(CPU_FTR_SUBCORE))
>  		return 0;
>
>  	/*
> -- 
> 2.5.0