Subject: Re: [PATCH v2 1/4] powerpc/pseries: hvcall.h: add H_WATCHDOG opcode, H_NOOP return code

From: Nathan Lynch <[email-masked]>
Date: Tue, 21 Jun 2022 09:44:42 -0500

Scott Cheloha <[email-masked]> writes:
> PAPR v2.12 defines a new hypercall, H_WATCHDOG.  The hypercall permits
> guest control of one or more virtual watchdog timers.
>
> Add the opcode for the H_WATCHDOG hypercall to hvcall.h.  While here,
> add a definition for H_NOOP, a possible return code for H_WATCHDOG.
>
> Signed-off-by: Scott Cheloha <[email-masked]>
> ---
>  arch/powerpc/include/asm/hvcall.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/include/asm/hvcall.h b/arch/powerpc/include/asm/hvcall.h
> index d92a20a85395..4b4f69c35b4f 100644
> --- a/arch/powerpc/include/asm/hvcall.h
> +++ b/arch/powerpc/include/asm/hvcall.h
> @@ -87,6 +87,7 @@
>  #define H_P7		-60
>  #define H_P8		-61
>  #define H_P9		-62
> +#define H_NOOP		-63
>  #define H_TOO_BIG	-64
>  #define H_UNSUPPORTED	-67
>  #define H_OVERLAP	-68

Not a problem to fix in your series, but I guess these should be
parenthesized i.e.

#define H_P7		(-60)
#define H_P8		(-61)
#define H_P9		(-62)
#define H_NOOP		(-63)

> @@ -324,7 +325,8 @@
>  #define H_RPT_INVALIDATE	0x448
>  #define H_SCM_FLUSH		0x44C
>  #define H_GET_ENERGY_SCALE_INFO	0x450
> -#define MAX_HCALL_OPCODE	H_GET_ENERGY_SCALE_INFO
> +#define H_WATCHDOG		0x45C
> +#define MAX_HCALL_OPCODE	H_WATCHDOG
>

Looks fine.

Reviewed-by: Nathan Lynch <[email-masked]>