Subject: Re: [PATCH 4/4] powerpc: Enable KFENCE on BOOK3S/64

From: Daniel Axtens <[email-masked]>
Date: Fri, 18 Jun 2021 18:02:07 +1000

Daniel Axtens <[email-masked]> writes:

>> +#ifdef CONFIG_PPC64
>> +static inline bool kfence_protect_page(unsigned long addr, bool protect)
>> +{
>> +	struct page *page;
>> +
>> +	page = virt_to_page(addr);
>> +	if (protect)
>> +		__kernel_map_pages(page, 1, 0);
>> +	else
>> +		__kernel_map_pages(page, 1, 1);
>
> I lose track of the type conversions and code conventions involved, but
> can we do something like __kernel_map_pages(page, 1, !!protect)?

Ah, I missed that the if changed the truth/falsity. !protect, not
!!protect :P
>
> Apart from that, this seems good.
>
> Kind regards,
> Daniel