From: Michael Ellerman <mpe@ellerman•id.au>
To: pc@us•ibm.com, Anshuman Khandual <khandual@linux•vnet.ibm.com>,
linuxppc-dev@lists•ozlabs.org
Cc: aneesh.kumar@linux•vnet.ibm.com
Subject: Re: [PATCH V4] powerpc/hugetlb: Add ABI defines for supported HugeTLB page sizes
Date: Sat, 08 Apr 2017 19:19:26 +1000 [thread overview]
Message-ID: <87a87rgstd.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <947e3e42-9c9e-a7b2-dc1b-0e5ffe747168@us.ibm.com>
Paul Clarke <pc@us•ibm.com> writes:
> nits... take 'em or leave 'em...
>
> On 04/07/2017 08:01 AM, Michael Ellerman wrote:
>> Anshuman Khandual <khandual@linux•vnet.ibm.com> writes:
>> And I reworded the comment the make it clearer (I think) that most users
>> shouldn't need to use these, and should just use the default size:
>>
>> /*
>> * When MAP_HUGETLB is set bits [26:31] encode the log2 of the huge page size.
>
> need a comma after "set".
Hmm, 'spose.
> also, "bits [26:31]" of what?
Flags!
But yeah fair cop, as it happened I was rebasing it anyway, so:
/*
* When MAP_HUGETLB is set, bits [26:31] of the flags argument to mmap(2),
* encode the log2 of the huge page size. A value of zero indicates that the
* default huge page size should be used. To use a non-default huge page size,
* one of these defines can be used, or the size can be encoded by hand. Note
* that on most systems only a subset, or possibly none, of these sizes will be
* available.
*/
Thanks for the review.
cheers
next prev parent reply other threads:[~2017-04-08 9:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-04 6:03 [PATCH] powerpc/hugetlb: Add ABI defines for MAP_HUGE_16MB and MAP_HUGE_16GB Anshuman Khandual
2017-04-04 8:33 ` Aneesh Kumar K.V
2017-04-04 13:50 ` Anshuman Khandual
2017-04-05 5:19 ` [PATCH V2] powerpc/hugetlb: Add ABI defines for supported HugeTLB page sizes Anshuman Khandual
2017-04-05 6:59 ` Balbir Singh
2017-04-05 7:09 ` Michael Ellerman
2017-04-05 11:20 ` [PATCH V3] " Anshuman Khandual
2017-04-06 19:03 ` LEROY Christophe
2017-04-07 3:47 ` Anshuman Khandual
2017-04-07 3:55 ` [PATCH V4] " Anshuman Khandual
2017-04-07 13:01 ` Michael Ellerman
2017-04-07 14:58 ` Anshuman Khandual
2017-04-07 15:44 ` Paul Clarke
2017-04-08 9:19 ` Michael Ellerman [this message]
2017-04-10 22:49 ` [V4] " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a87rgstd.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=aneesh.kumar@linux$(echo .)vnet.ibm.com \
--cc=khandual@linux$(echo .)vnet.ibm.com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=pc@us$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox