From: Michael Ellerman <mpe@ellerman•id.au>
To: Ben Hutchings <ben@decadent•org.uk>, linuxppc-dev@lists•ozlabs.org
Cc: Alexander Graf <agraf@suse•de>,
Benjamin Herrenschmidt <benh@kernel•crashing.org>,
<paulus@samba•org>
Subject: Re: [PATCH 1/2] powerpc: Remove Mac-on-Linux hooks
Date: Fri, 02 Dec 2016 14:56:47 +1100 [thread overview]
Message-ID: <87a8cf7zls.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20161202023552.GJ2697@decadent.org.uk>
Ben Hutchings <ben@decadent•org.uk> writes:
> [ Unknown signature status ]
> The symbols exported for use by MOL aren't getting CRCs and I was
> about to fix that. But MOL is dead upstream, and the latest work on
> it was to make it use KVM instead of its own kernel module. So remove
> them instead.
Sounds good to me.
> diff --git a/arch/powerpc/kernel/head_32.S b/arch/powerpc/kernel/head_32.S
> index 9d963547d243..87998430cd9b 100644
> --- a/arch/powerpc/kernel/head_32.S
> +++ b/arch/powerpc/kernel/head_32.S
> @@ -735,11 +735,7 @@ END_MMU_FTR_SECTION_IFSET(MMU_FTR_NEED_DTLB_SW_LRU)
> EXCEPTION(0x2c00, Trap_2c, unknown_exception, EXC_XFER_EE)
> EXCEPTION(0x2d00, Trap_2d, unknown_exception, EXC_XFER_EE)
> EXCEPTION(0x2e00, Trap_2e, unknown_exception, EXC_XFER_EE)
> - EXCEPTION(0x2f00, MOLTrampoline, unknown_exception, EXC_XFER_EE_LITE)
> -
> - .globl mol_trampoline
> - .set mol_trampoline, i0x2f00
> - EXPORT_SYMBOL(mol_trampoline)
> + EXCEPTION(0x2f00, Trap_2f, unknown_exception, EXC_XFER_EE)
>
> . = 0x3000
>
> @@ -1289,7 +1285,6 @@ intercept_table:
> .long 0, 0, 0, 0, 0, 0, 0, 0
> .long 0, 0, 0, 0, 0, 0, 0, 0
> .long 0, 0, 0, 0, 0, 0, 0, 0
> -EXPORT_SYMBOL(intercept_table)
I don't see intercept_table used anywhere, so I think we can just remove
it entirely?
> diff --git a/arch/powerpc/mm/hash_low_32.S b/arch/powerpc/mm/hash_low_32.S
> index 09cc50c8dace..cddf14f60bf3 100644
> --- a/arch/powerpc/mm/hash_low_32.S
> +++ b/arch/powerpc/mm/hash_low_32.S
> @@ -34,7 +34,6 @@
> .globl mmu_hash_lock
> mmu_hash_lock:
> .space 4
> -EXPORT_SYMBOL(mmu_hash_lock)
> #endif /* CONFIG_SMP */
And now mmu_hash_lock is only used in this file, so doesn't need to be
global anymore.
I can fix both of those up here, will just wait a bit to see if anyone
else has comments.
cheers
next prev parent reply other threads:[~2016-12-02 3:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 2:35 [PATCH 1/2] powerpc: Remove Mac-on-Linux hooks Ben Hutchings
2016-12-02 2:38 ` [PATCH 2/2] powerpc: Fix missing CRCs, add yet more asm-prototypes.h declarations Ben Hutchings
2017-03-21 11:36 ` [2/2] " Michael Ellerman
2016-12-02 3:56 ` Michael Ellerman [this message]
2016-12-02 5:05 ` [PATCH 1/2] powerpc: Remove Mac-on-Linux hooks Ben Hutchings
2017-03-21 11:36 ` [1/2] " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8cf7zls.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=agraf@suse$(echo .)de \
--cc=ben@decadent$(echo .)org.uk \
--cc=benh@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox