Subject: Re: [PATCH 3/3] powerpc/mm: Use VMALLOC_START to validate addr

From: Michael Ellerman <[email-masked]>
Date: Fri, 24 Jun 2022 12:45:24 +1000

"Aneesh Kumar K.V" <[email-masked]> writes:
> Instead of high_memory use VMALLOC_START to validate that the address is
> not in the vmalloc range.
>
> Cc: Kefeng Wang <[email-masked]>
> Cc: Christophe Leroy <[email-masked]>
> Signed-off-by: Aneesh Kumar K.V <[email-masked]>

Isn't this really the fix for ffa0b64e3be5 ("powerpc: Fix
virt_addr_valid() for 64-bit Book3E & 32-bit") ?

cheers

> diff --git a/arch/powerpc/include/asm/page.h b/arch/powerpc/include/asm/page.h
> index e5f75c70eda8..256cad69e42e 100644
> --- a/arch/powerpc/include/asm/page.h
> +++ b/arch/powerpc/include/asm/page.h
> @@ -134,7 +134,7 @@ static inline bool pfn_valid(unsigned long pfn)
>  
>  #define virt_addr_valid(vaddr)	({					\
>  	unsigned long _addr = (unsigned long)vaddr;			\
> -	_addr >= PAGE_OFFSET && _addr < (unsigned long)high_memory &&	\
> +	_addr >= PAGE_OFFSET && _addr < (unsigned long)VMALLOC_START &&	\
>  	pfn_valid(virt_to_pfn(_addr));					\
>  })
>  
> -- 
> 2.36.1