Subject: Re: [PATCH] powerpc: Mark arch_get_ima_policy() and is_ppc_trustedboot_enabled() as __init

From: Michael Ellerman <[email-masked]>
Date: Sat, 09 Apr 2022 23:04:15 +1000

Mimi Zohar <[email-masked]> writes:
> On Fri, 2022-04-08 at 13:31 -0400, Mimi Zohar wrote:
>> On Fri, 2022-04-08 at 12:05 -0400, Mimi Zohar wrote:
>> > On Fri, 2022-04-08 at 00:15 +1000, Michael Ellerman wrote:
>> > > We can mark arch_get_ima_policy() as __init because it's only caller
>> > > ima_init_arch_policy() is __init. We can then mark
>> > > is_ppc_trustedboot_enabled() __init because its only caller is
>> > > arch_get_ima_policy().
>> > > 
>> > > Signed-off-by: Michael Ellerman <[email-masked]>
>> > 
>> > I assume you want to upstream this via power,
>> > 
>> >     Reviewed-by: Mimi Zohar <[email-masked]>
>> 
>> Sorry, I just noticed that is_ppc_trustedboot_enabled() is also called
>> by arch_ima_get_secureboot().
>
> Never mind, arch_ima_get_secureboot() calls
> is_ppc_secureboot_enabled(), not is_ppc_trustedboot_enabled().

Yeah despite the long names they are still easy to confuse :)

cheers