From: Michael Ellerman <mpe@ellerman•id.au>
To: Nicholas Piggin <npiggin@gmail•com>, Haren Myneni <haren@linux•ibm.com>
Cc: mikey@neuling•org, ajd@linux•ibm.com, hch@infradead•org,
oohall@gmail•com, sukadev@linux•vnet.ibm.com,
linuxppc-dev@lists•ozlabs.org, herbert@gondor•apana.org.au
Subject: Re: [PATCH v8 03/14] powerpc/vas: Define nx_fault_stamp in coprocessor_request_block
Date: Mon, 23 Mar 2020 22:32:02 +1100 [thread overview]
Message-ID: <87bloncnnx.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <1584923120.arc9bj6gmg.astroid@bobo.none>
Nicholas Piggin <npiggin@gmail•com> writes:
> Haren Myneni's on March 19, 2020 4:13 pm:
>>
>> Kernel sets fault address and status in CRB for NX page fault on user
>> space address after processing page fault. User space gets the signal
>> and handles the fault mentioned in CRB by bringing the page in to
>> memory and send NX request again.
>>
>> Signed-off-by: Sukadev Bhattiprolu <sukadev@linux•vnet.ibm.com>
>> Signed-off-by: Haren Myneni <haren@linux•ibm.com>
>> ---
>> arch/powerpc/include/asm/icswx.h | 18 +++++++++++++++++-
>> 1 file changed, 17 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/powerpc/include/asm/icswx.h b/arch/powerpc/include/asm/icswx.h
>> index 9872f85..b233d1e 100644
>> --- a/arch/powerpc/include/asm/icswx.h
>> +++ b/arch/powerpc/include/asm/icswx.h
>
> "icswx" is not a thing anymore, after 6ff4d3e96652 ("powerpc: Remove old
> unused icswx based coprocessor support").
Yeah that commit ripped out some parts of the previous attempt at a user
visible API for this sort of "coprocessor" stuff. VAS is yet another
attempt to do something useful with most of the same pieces but some
slightly different details.
> I guess NX is reusing some
> things from it, but it would be good to get rid of the cruft and re-name
> this file and and relevant names.
> NX already uses this file, so I guesss that can happen after this series.
A lot of the CRB/CSB stuff is still the same, and P8 still uses icswx.
But I'd be happy if the header was renamed eventually, as icswx is now a
legacy name.
cheers
next prev parent reply other threads:[~2020-03-23 11:34 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 6:08 [PATCH v8 00/14] powerpc/vas: Page fault handling for user space NX requests Haren Myneni
2020-03-19 6:12 ` [PATCH v8 01/14] powerpc/xive: Define xive_native_alloc_irq_on_chip() Haren Myneni
2020-03-23 0:20 ` Nicholas Piggin
2020-03-23 8:32 ` Cédric Le Goater
2020-03-24 13:48 ` Cédric Le Goater
2020-03-19 6:13 ` [PATCH v8 02/14] powerpc/xive: Define xive_native_alloc_get_irq_info() Haren Myneni
2020-03-23 8:52 ` Cédric Le Goater
2020-03-24 13:51 ` Cédric Le Goater
2020-03-19 6:13 ` [PATCH v8 03/14] powerpc/vas: Define nx_fault_stamp in coprocessor_request_block Haren Myneni
2020-03-23 0:30 ` Nicholas Piggin
2020-03-23 0:57 ` Haren Myneni
2020-03-23 1:30 ` Nicholas Piggin
2020-03-23 11:32 ` Michael Ellerman [this message]
2020-03-23 18:13 ` Haren Myneni
2020-03-25 10:44 ` Michael Ellerman
2020-03-19 6:14 ` [PATCH v8 04/14] powerpc/vas: Alloc and setup IRQ and trigger port address Haren Myneni
2020-03-23 1:06 ` Nicholas Piggin
2020-03-23 9:06 ` Cédric Le Goater
2020-03-23 9:27 ` Cédric Le Goater
2020-03-23 19:02 ` Haren Myneni
2020-03-24 12:20 ` Cédric Le Goater
2020-03-24 2:26 ` Oliver O'Halloran
2020-03-24 13:27 ` Cédric Le Goater
2020-03-24 14:48 ` Cédric Le Goater
2020-03-24 21:06 ` Haren Myneni
2020-03-19 6:15 ` [PATCH v8 05/14] powerpc/vas: Setup fault window per VAS instance Haren Myneni
2020-03-19 6:15 ` [PATCH v8 06/14] powerpc/vas: Setup thread IRQ handler " Haren Myneni
2020-03-23 2:23 ` Nicholas Piggin
2020-03-25 2:58 ` Haren Myneni
2020-03-19 6:16 ` [PATCH v8 07/14] powerpc/vas: Register NX with fault window ID and IRQ port value Haren Myneni
2020-03-19 6:16 ` [PATCH v8 08/14] powerpc/vas: Take reference to PID and mm for user space windows Haren Myneni
2020-03-23 2:34 ` Nicholas Piggin
2020-03-19 6:17 ` [PATCH v8 09/14] powerpc/vas: Update CSB and notify process for fault CRBs Haren Myneni
2020-03-23 2:37 ` Nicholas Piggin
2020-03-19 6:18 ` [PATCH v8 10/14] powerpc/vas: Print CRB and FIFO values Haren Myneni
2020-03-19 6:18 ` [PATCH v8 11/14] powerpc/vas: Do not use default credits for receive window Haren Myneni
2020-03-23 2:40 ` Nicholas Piggin
2020-03-25 3:04 ` Haren Myneni
2020-03-19 6:19 ` [PATCH v8 12/14] powerpc/vas: Return credits after handling fault Haren Myneni
2020-03-23 2:44 ` Nicholas Piggin
2020-03-25 3:35 ` Haren Myneni
2020-03-19 6:19 ` [PATCH v8 13/14] powerpc/vas: Display process stuck message Haren Myneni
2020-03-19 6:20 ` [PATCH v8 14/14] powerpc/vas: Free send window in VAS instance after credits returned Haren Myneni
2020-03-23 8:59 ` [PATCH v8 00/14] powerpc/vas: Page fault handling for user space NX requests Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bloncnnx.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=ajd@linux$(echo .)ibm.com \
--cc=haren@linux$(echo .)ibm.com \
--cc=hch@infradead$(echo .)org \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mikey@neuling$(echo .)org \
--cc=npiggin@gmail$(echo .)com \
--cc=oohall@gmail$(echo .)com \
--cc=sukadev@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox