Subject: Re: [PATCH 3/4] powerpc/xive: shutdown XIVE when kexec or kdump is performed

From: Michael Ellerman <[email-masked]>
Date: Fri, 04 May 2018 20:42:06 +1000

Cédric Le Goater <[email-masked]> writes:

> The hcall H_INT_RESET should be called to make sure XIVE is fully
> reseted.
>
> Signed-off-by: Cédric Le Goater <[email-masked]>
> ---
>  arch/powerpc/platforms/pseries/kexec.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/platforms/pseries/kexec.c b/arch/powerpc/platforms/pseries/kexec.c
> index eeb13429d685..1d9bbf8e7357 100644
> --- a/arch/powerpc/platforms/pseries/kexec.c
> +++ b/arch/powerpc/platforms/pseries/kexec.c
> @@ -52,8 +52,11 @@ void pseries_kexec_cpu_down(int crash_shutdown, int secondary)
>  		}
>  	}
>  
> -	if (xive_enabled())
> +	if (xive_enabled()) {
>  		xive_kexec_teardown_cpu(secondary);
> -	else
> +
> +		if (!secondary)
> +			xive_shutdown();

Couldn't that logic go in xive_kexec_teardown_cpu()?

Why do we not want to do it on powernv?

Actually we *do* do it on powernv, but elsewhere.

cheers

> +	} else
>  		xics_kexec_teardown_cpu(secondary);
>  }
> -- 
> 2.13.6