From: Shea Levy <shea@shealevy•com>
To: Ingo Molnar <mingo@kernel•org>
Cc: linux-riscv@lists•infradead.org, linux-kernel@vger•kernel.org,
"Christoph Hellwig" <hch@infradead•org>,
"Richard Henderson" <rth@twiddle•net>,
"Ivan Kokshaysky" <ink@jurassic•park.msu.ru>,
"Matt Turner" <mattst88@gmail•com>,
"Vineet Gupta" <vgupta@synopsys•com>,
"Russell King" <linux@armlinux•org.uk>,
"Catalin Marinas" <catalin.marinas@arm•com>,
"Will Deacon" <will.deacon@arm•com>,
"Mark Salter" <msalter@redhat•com>,
"Aurelien Jacquiot" <jacquiot.aurelien@gmail•com>,
"Mikael Starvik" <starvik@axis•com>,
"Jesper Nilsson" <jesper.nilsson@axis•com>,
"Yoshinori Sato" <ysato@users•sourceforge.jp>,
"Richard Kuo" <rkuo@codeaurora•org>,
"Tony Luck" <tony.luck@intel•com>,
"Fenghua Yu" <fenghua.yu@intel•com>,
"Geert Uytterhoeven" <geert@linux-m68k•org>,
"James Hogan" <jhogan@kernel•org>,
"Michal Simek" <monstr@monstr•eu>,
"Ralf Baechle" <ralf@linux-mips•org>,
"David Howells" <dhowells@redhat•com>,
"Ley Foon Tan" <lftan@altera•com>,
"Jonas Bonn" <jonas@southpole•se>,
"Stefan Kristiansson" <stefan.kristiansson@saunalahti•fi>,
"Stafford Horne" <shorne@gmail•com>,
"James E.J. Bottomley" <jejb@parisc-linux•org>,
"Helge Deller" <deller@gmx•de>,
"Benjamin Herrenschmidt" <benh@kernel•crashing.org>,
"Paul Mackerras" <paulus@samba•org>,
"Michael Ellerman" <mpe@ellerman•id.au>,
"Palmer Dabbelt" <palmer@sifive•com>,
"Albert Ou" <albert@sifive•com>,
"Martin Schwidefsky" <schwidefsky@de•ibm.com>,
"Heiko Carstens" <heiko.carstens@de•ibm.com>,
"Chen Liqin" <liqin.linux@gmail•com>,
"Lennox Wu" <lennox.wu@gmail•com>,
"Rich Felker" <dalias@libc•org>,
"David S. Miller" <davem@davemloft•net>,
"Jeff Dike" <jdike@addtoit•com>,
"Richard Weinberger" <richard@nod•at>,
"Guan Xuetao" <gxt@mprc•pku.edu.cn>,
"Thomas Gleixner" <tglx@linutronix•de>,
"Ingo Molnar" <mingo@redhat•com>,
"H. Peter Anvin" <hpa@zytor•com>,
x86@kernel•org, "Chris Zankel" <chris@zankel•net>,
"Max Filippov" <jcmvbkbc@gmail•com>,
"Kate Stewart" <kstewart@linuxfoundation•org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation•org>,
"Philippe Ombredanne" <pombredanne@nexb•com>,
"Eugeniy Paltsev" <Eugeniy.Paltsev@synopsys•com>,
"Al Viro" <viro@zeniv•linux.org.uk>,
"Vladimir Murzin" <vladimir.murzin@arm•com>,
"Linus Walleij" <linus.walleij@linaro•org>,
"Michal Hocko" <mhocko@suse•com>,
"Andrew Morton" <akpm@linux-foundation•org>,
"Sudip Mukherjee" <sudipm.mukherjee@gmail•com>,
"Marc Zyngier" <marc.zyngier@arm•com>,
"Rob Herring" <robh@kernel•org>,
"Kees Cook" <keescook@chromium•org>,
"Vlastimil Babka" <vbabka@suse•cz>,
"Balbir Singh" <bsingharora@gmail•com>,
"Christophe Leroy" <christophe.leroy@c-s•fr>,
"Joe Perches" <joe@perches•com>,
"Oliver O'Halloran" <oohall@gmail•com>,
"Dan Williams" <dan.j.williams@intel•com>,
"Wei Yang" <richard.weiyang@gmail•com>,
"Christian König" <christian.koenig@amd•com>,
"Arnd Bergmann" <arnd@arndb•de>,
"Deepa Dinamani" <deepa.kernel@gmail•com>,
"Daniel Thompson" <daniel.thompson@linaro•org>,
"Rob Landley" <rob@landley•net>,
"Florian Fainelli" <f.fainelli@gmail•com>,
linux-alpha@vger•kernel.org, linux-snps-arc@lists•infradead.org,
linux-arm-kernel@lists•infradead.org,
adi-buildroot-devel@lists•sourceforge.net,
linux-c6x-dev@linux-c6x•org, linux-cris-kernel@axis•com,
uclinux-h8-devel@lists•sourceforge.jp,
linux-hexagon@vger•kernel.org, linux-ia64@vger•kernel.org,
linux-m68k@lists•linux-m68k.org, linux-metag@vger•kernel.org,
linux-mips@linux-mips•org, linux-am33-list@redhat•com,
nios2-dev@lists•rocketboards.org, openrisc@lists•librecores.org,
linux-parisc@vger•kernel.org, linuxppc-dev@lists•ozlabs.org,
linux-s390@vger•kernel.org, linux-sh@vger•kernel.org,
sparclinux@vger•kernel.org,
user-mode-linux-devel@lists•sourceforge.net,
user-mode-linux-user@lists•sourceforge.net,
linux-xtensa@linux-xtensa•org
Subject: Re: [PATCH] Extract initrd free logic from arch-specific code.
Date: Sun, 01 Apr 2018 11:05:21 -0400 [thread overview]
Message-ID: <87bmf3rmq6.fsf@xps13.shealevy.com> (raw)
In-Reply-To: <20180330111517.rrx6gs2skkgk336j@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3181 bytes --]
Hi Ingo,
Ingo Molnar <mingo@kernel•org> writes:
> * Shea Levy <shea@shealevy•com> wrote:
>
>> Now only those architectures that have custom initrd free requirements
>> need to define free_initrd_mem.
>>
>> Signed-off-by: Shea Levy <shea@shealevy•com>
>
> Please put the Kconfig symbol name this patch introduces both into the title, so
> that people know what to grep for.
>
>> ---
>> arch/alpha/mm/init.c | 8 --------
>> arch/arc/mm/init.c | 7 -------
>> arch/arm/Kconfig | 1 +
>> arch/arm64/Kconfig | 1 +
>> arch/blackfin/Kconfig | 1 +
>> arch/c6x/mm/init.c | 7 -------
>> arch/cris/Kconfig | 1 +
>> arch/frv/mm/init.c | 11 -----------
>> arch/h8300/mm/init.c | 7 -------
>> arch/hexagon/Kconfig | 1 +
>> arch/ia64/Kconfig | 1 +
>> arch/m32r/Kconfig | 1 +
>> arch/m32r/mm/init.c | 11 -----------
>> arch/m68k/mm/init.c | 7 -------
>> arch/metag/Kconfig | 1 +
>> arch/microblaze/mm/init.c | 7 -------
>> arch/mips/Kconfig | 1 +
>> arch/mn10300/Kconfig | 1 +
>> arch/nios2/mm/init.c | 7 -------
>> arch/openrisc/mm/init.c | 7 -------
>> arch/parisc/mm/init.c | 7 -------
>> arch/powerpc/mm/mem.c | 7 -------
>> arch/riscv/mm/init.c | 6 ------
>> arch/s390/Kconfig | 1 +
>> arch/score/Kconfig | 1 +
>> arch/sh/mm/init.c | 7 -------
>> arch/sparc/Kconfig | 1 +
>> arch/tile/Kconfig | 1 +
>> arch/um/kernel/mem.c | 7 -------
>> arch/unicore32/Kconfig | 1 +
>> arch/x86/Kconfig | 1 +
>> arch/xtensa/Kconfig | 1 +
>> init/initramfs.c | 7 +++++++
>> usr/Kconfig | 4 ++++
>> 34 files changed, 28 insertions(+), 113 deletions(-)
>
> Please also put it into Documentation/features/.
>
I switched this patch series (the latest revision v6 was just posted) to
using weak symbols instead of Kconfig. Does it still warrant documentation?
>
>> diff --git a/usr/Kconfig b/usr/Kconfig
>> index 43658b8a975e..7a94f6df39bf 100644
>> --- a/usr/Kconfig
>> +++ b/usr/Kconfig
>> @@ -233,3 +233,7 @@ config INITRAMFS_COMPRESSION
>> default ".lzma" if RD_LZMA
>> default ".bz2" if RD_BZIP2
>> default ""
>> +
>> +config HAVE_ARCH_FREE_INITRD_MEM
>> + bool
>> + default n
>
> Help text would be nice, to tell arch maintainers what the purpose of this switch
> is.
>
> Also, a nit, I think this should be named "ARCH_HAS_FREE_INITRD_MEM", which is the
> dominant pattern:
>
> triton:~/tip> git grep 'select.*ARCH' arch/x86/Kconfig* | cut -f2 | cut -d_ -f1-2 | sort | uniq -c | sort -n
> ...
> 2 select ARCH_USES
> 2 select ARCH_WANTS
> 3 select ARCH_MIGHT
> 3 select ARCH_WANT
> 4 select ARCH_SUPPORTS
> 4 select ARCH_USE
> 16 select HAVE_ARCH
> 23 select ARCH_HAS
>
> It also reads nicely in English:
>
> "arch has free_initrd_mem()"
>
> While the other makes little sense:
>
> "have arch free_initrd_mem()"
>
> ?
>
> Thanks,
>
> Ingo
Thanks,
Shea
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2018-04-01 15:05 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-24 17:44 [PATCH 00/16] Generic infrastructure for unloading initramfs Shea Levy
2018-03-24 17:44 ` [PATCH 01/16] initrd: Add generic code path for common initrd unloading logic Shea Levy
2018-03-25 17:17 ` LEROY Christophe
2018-03-25 22:20 ` Shea Levy
2018-03-28 12:04 ` Christoph Hellwig
2018-03-28 12:23 ` Geert Uytterhoeven
2018-03-24 17:44 ` [PATCH 02/16] riscv: Use INITRAMFS_GENERIC_UNLOAD Shea Levy
2018-03-24 17:44 ` [PATCH 03/16] alpha: " Shea Levy
2018-03-24 17:44 ` [PATCH 04/16] arc: " Shea Levy
2018-03-24 17:44 ` [PATCH 05/16] c6x: " Shea Levy
2018-03-24 17:44 ` [PATCH 06/16] frv: " Shea Levy
2018-03-24 17:44 ` [PATCH 07/16] h8300: " Shea Levy
2018-03-24 17:44 ` [PATCH 08/16] m32r: " Shea Levy
2018-03-24 17:44 ` [PATCH 09/16] m68k: " Shea Levy
2018-03-24 17:44 ` [PATCH 10/16] microblaze: " Shea Levy
2018-03-24 17:44 ` [PATCH 11/16] nios2: " Shea Levy
2018-03-24 17:44 ` [PATCH 12/16] openrisc: " Shea Levy
2018-03-24 17:44 ` [PATCH 13/16] parisc: " Shea Levy
2018-03-24 17:44 ` [PATCH 14/16] powerpc: " Shea Levy
2018-03-24 17:44 ` [PATCH 15/16] sh: " Shea Levy
2018-03-24 17:44 ` [PATCH 16/16] um: " Shea Levy
2018-03-25 22:18 ` [PATCH v2 00/16] Generic infrastructure for unloading initramfs Shea Levy
2018-03-25 22:18 ` [PATCH v2 01/16] initrd: Add generic code path for common initrd unloading logic Shea Levy
2018-03-25 22:18 ` [PATCH v2 02/16] riscv: Use INITRAMFS_GENERIC_UNLOAD Shea Levy
2018-03-26 0:41 ` Palmer Dabbelt
2018-03-26 0:55 ` Shea Levy
2018-03-25 22:18 ` [PATCH v2 03/16] alpha: " Shea Levy
2018-03-25 22:18 ` [PATCH v2 04/16] arc: " Shea Levy
2018-03-25 22:18 ` [PATCH v2 05/16] c6x: " Shea Levy
2018-03-25 22:18 ` [PATCH v2 06/16] frv: " Shea Levy
2018-03-25 22:18 ` [PATCH v2 07/16] h8300: " Shea Levy
2018-03-25 22:18 ` [PATCH v2 08/16] m32r: " Shea Levy
2018-03-25 22:18 ` [PATCH v2 09/16] m68k: " Shea Levy
2018-03-25 22:18 ` [PATCH v2 10/16] microblaze: " Shea Levy
2018-03-25 22:18 ` [PATCH v2 11/16] nios2: " Shea Levy
2018-03-25 22:18 ` [PATCH v2 12/16] openrisc: " Shea Levy
2018-03-25 22:18 ` [PATCH v2 13/16] parisc: " Shea Levy
2018-03-25 22:18 ` [PATCH v2 14/16] powerpc: " Shea Levy
2018-03-25 22:18 ` [PATCH v2 15/16] sh: " Shea Levy
2018-03-25 22:18 ` [PATCH v2 16/16] um: " Shea Levy
2018-03-28 15:26 ` [PATCH] Extract initrd free logic from arch-specific code Shea Levy
2018-03-28 15:58 ` Rob Landley
2018-03-28 16:04 ` Shea Levy
2018-03-28 16:48 ` Russell King - ARM Linux
2018-03-28 19:04 ` Rob Landley
2018-03-28 22:14 ` Russell King - ARM Linux
2018-03-28 22:37 ` Oliver
2018-03-29 0:23 ` Nicholas Piggin
2018-03-29 15:27 ` Russell King - ARM Linux
2018-03-29 15:43 ` Geert Uytterhoeven
2018-03-29 15:58 ` Russell King - ARM Linux
2018-03-29 16:53 ` Marc Zyngier
2018-03-29 17:32 ` Russell King - ARM Linux
2018-03-29 17:53 ` Marc Zyngier
2018-03-29 17:43 ` Rob Landley
2018-03-29 16:39 ` Rob Landley
2018-03-29 17:31 ` Russell King - ARM Linux
2018-03-28 16:55 ` Kees Cook
2018-03-29 1:12 ` Wei Yang
[not found] ` <20180328203659.18692-1-shea@shealevy.com>
2018-03-28 20:36 ` [PATCH v4 14/16] powerpc: Use generic free_initrd_mem Shea Levy
2018-03-28 20:44 ` Joe Perches
2018-03-28 20:53 ` Shea Levy
2018-03-29 13:19 ` Michael Ellerman
2018-04-01 15:01 ` Shea Levy
[not found] ` <20180329113207.30674-1-shea@shealevy.com>
2018-03-29 11:32 ` [PATCH v5 14/16] powerpc: Switch to " Shea Levy
[not found] ` <20180401145931.7932-1-shea@shealevy.com>
2018-04-01 14:59 ` [PATCH v6 " Shea Levy
2018-03-30 1:43 ` [PATCH] Extract initrd free logic from arch-specific code kbuild test robot
2018-03-30 3:16 ` kbuild test robot
2018-03-30 11:15 ` Ingo Molnar
2018-04-01 15:05 ` Shea Levy [this message]
2018-04-02 5:59 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bmf3rmq6.fsf@xps13.shealevy.com \
--to=shea@shealevy$(echo .)com \
--cc=Eugeniy.Paltsev@synopsys$(echo .)com \
--cc=adi-buildroot-devel@lists$(echo .)sourceforge.net \
--cc=akpm@linux-foundation$(echo .)org \
--cc=albert@sifive$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=benh@kernel$(echo .)crashing.org \
--cc=bsingharora@gmail$(echo .)com \
--cc=catalin.marinas@arm$(echo .)com \
--cc=chris@zankel$(echo .)net \
--cc=christian.koenig@amd$(echo .)com \
--cc=christophe.leroy@c-s$(echo .)fr \
--cc=dalias@libc$(echo .)org \
--cc=dan.j.williams@intel$(echo .)com \
--cc=daniel.thompson@linaro$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=deepa.kernel@gmail$(echo .)com \
--cc=deller@gmx$(echo .)de \
--cc=dhowells@redhat$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=fenghua.yu@intel$(echo .)com \
--cc=geert@linux-m68k$(echo .)org \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=gxt@mprc$(echo .)pku.edu.cn \
--cc=hch@infradead$(echo .)org \
--cc=heiko.carstens@de$(echo .)ibm.com \
--cc=hpa@zytor$(echo .)com \
--cc=ink@jurassic$(echo .)park.msu.ru \
--cc=jacquiot.aurelien@gmail$(echo .)com \
--cc=jcmvbkbc@gmail$(echo .)com \
--cc=jdike@addtoit$(echo .)com \
--cc=jejb@parisc-linux$(echo .)org \
--cc=jesper.nilsson@axis$(echo .)com \
--cc=jhogan@kernel$(echo .)org \
--cc=joe@perches$(echo .)com \
--cc=jonas@southpole$(echo .)se \
--cc=keescook@chromium$(echo .)org \
--cc=kstewart@linuxfoundation$(echo .)org \
--cc=lennox.wu@gmail$(echo .)com \
--cc=lftan@altera$(echo .)com \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-alpha@vger$(echo .)kernel.org \
--cc=linux-am33-list@redhat$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-c6x-dev@linux-c6x$(echo .)org \
--cc=linux-cris-kernel@axis$(echo .)com \
--cc=linux-hexagon@vger$(echo .)kernel.org \
--cc=linux-ia64@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-m68k@lists$(echo .)linux-m68k.org \
--cc=linux-metag@vger$(echo .)kernel.org \
--cc=linux-mips@linux-mips$(echo .)org \
--cc=linux-parisc@vger$(echo .)kernel.org \
--cc=linux-riscv@lists$(echo .)infradead.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=linux-snps-arc@lists$(echo .)infradead.org \
--cc=linux-xtensa@linux-xtensa$(echo .)org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=liqin.linux@gmail$(echo .)com \
--cc=marc.zyngier@arm$(echo .)com \
--cc=mattst88@gmail$(echo .)com \
--cc=mhocko@suse$(echo .)com \
--cc=mingo@kernel$(echo .)org \
--cc=mingo@redhat$(echo .)com \
--cc=monstr@monstr$(echo .)eu \
--cc=mpe@ellerman$(echo .)id.au \
--cc=msalter@redhat$(echo .)com \
--cc=nios2-dev@lists$(echo .)rocketboards.org \
--cc=oohall@gmail$(echo .)com \
--cc=openrisc@lists$(echo .)librecores.org \
--cc=palmer@sifive$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=pombredanne@nexb$(echo .)com \
--cc=ralf@linux-mips$(echo .)org \
--cc=richard.weiyang@gmail$(echo .)com \
--cc=richard@nod$(echo .)at \
--cc=rkuo@codeaurora$(echo .)org \
--cc=rob@landley$(echo .)net \
--cc=robh@kernel$(echo .)org \
--cc=rth@twiddle$(echo .)net \
--cc=schwidefsky@de$(echo .)ibm.com \
--cc=shorne@gmail$(echo .)com \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=starvik@axis$(echo .)com \
--cc=stefan.kristiansson@saunalahti$(echo .)fi \
--cc=sudipm.mukherjee@gmail$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=tony.luck@intel$(echo .)com \
--cc=uclinux-h8-devel@lists$(echo .)sourceforge.jp \
--cc=user-mode-linux-devel@lists$(echo .)sourceforge.net \
--cc=user-mode-linux-user@lists$(echo .)sourceforge.net \
--cc=vbabka@suse$(echo .)cz \
--cc=vgupta@synopsys$(echo .)com \
--cc=viro@zeniv$(echo .)linux.org.uk \
--cc=vladimir.murzin@arm$(echo .)com \
--cc=will.deacon@arm$(echo .)com \
--cc=x86@kernel$(echo .)org \
--cc=ysato@users$(echo .)sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox