public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman•id.au>
To: Michael Neuling <mikey@neuling•org>,
	"Gautham R. Shenoy" <ego@linux•vnet.ibm.com>,
	Benjamin Herrenschmidt <benh@kernel•crashing.org>,
	"Shreyas B. Prabhu" <shreyasbp@gmail•com>,
	Shilpasri G Bhat <shilpa.bhat@linux•vnet.ibm.com>,
	Vaidyanathan Srinivasan <svaidy@linux•vnet.ibm.com>,
	Anton Blanchard <anton@samba•org>,
	Balbir Singh <bsingharora@gmail•com>,
	Akshay Adiga <akshay.adiga@linux•vnet.ibm.com>,
	Nicholas Piggin <npiggin@gmail•com>,
	Mahesh J Salgaonkar <mahesh@linux•vnet.ibm.com>,
	"Aneesh Kumar K.V" <aneesh.kumar@linux•vnet.ibm.com>
Cc: linuxppc-dev@lists•ozlabs.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH 1/3] powernv:idle: Use correct IDLE_THREAD_BITS in POWER8/9
Date: Thu, 13 Apr 2017 20:00:47 +1000	[thread overview]
Message-ID: <87bms0aapc.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <1492065380.4624.50.camel@neuling.org>

Michael Neuling <mikey@neuling•org> writes:

> On Wed, 2017-04-12 at 17:16 +0530, Gautham R. Shenoy wrote:
>> From: "Gautham R. Shenoy" <ego@linux•vnet.ibm.com>
>> 
>> This patch ensures that POWER8 and POWER9 processors use the correct
>> value of IDLE_THREAD_BITS as POWER8 has 8 threads per core and hence
>> the IDLE_THREAD_BITS should be 0xFF while POWER9 has only 4 threads
>> per core and hence the IDLE_THREAD_BITS should be 0xF.
>
> Why don't we derive this from the device tree rather than hard wiring it per cpu
> type?

Right.

In fact we already have threads_per_core which is exactly that.

cheers

  reply	other threads:[~2017-04-13 10:00 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-12 11:46 [PATCH 0/3] powernv:stop: Some fixes for handling deep stop Gautham R. Shenoy
2017-04-12 11:46 ` [PATCH 1/3] powernv:idle: Use correct IDLE_THREAD_BITS in POWER8/9 Gautham R. Shenoy
2017-04-13  6:36   ` Michael Neuling
2017-04-13 10:00     ` Michael Ellerman [this message]
2017-04-13 11:35       ` Gautham R Shenoy
2017-04-12 11:46 ` [PATCH 2/3] powernv:idle: Decouple TB restore & Per-core SPRs restore Gautham R. Shenoy
2017-04-13  6:55   ` Michael Neuling
2017-04-13 11:51     ` Gautham R Shenoy
2017-04-12 11:46 ` [PATCH 3/3] powernv:idle: Set LPCR_UPRT on wakeup from deep-stop Gautham R. Shenoy
2017-04-13  3:58   ` Aneesh Kumar K.V
2017-04-13  4:12     ` Benjamin Herrenschmidt
2017-04-13  6:27       ` Michael Neuling
2017-04-13  7:18         ` Nicholas Piggin
2017-04-13 10:05           ` Michael Ellerman
2017-04-13 11:54           ` Gautham R Shenoy
2017-04-13 12:08             ` Nicholas Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bms0aapc.fsf@concordia.ellerman.id.au \
    --to=mpe@ellerman$(echo .)id.au \
    --cc=akshay.adiga@linux$(echo .)vnet.ibm.com \
    --cc=aneesh.kumar@linux$(echo .)vnet.ibm.com \
    --cc=anton@samba$(echo .)org \
    --cc=benh@kernel$(echo .)crashing.org \
    --cc=bsingharora@gmail$(echo .)com \
    --cc=ego@linux$(echo .)vnet.ibm.com \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linuxppc-dev@lists$(echo .)ozlabs.org \
    --cc=mahesh@linux$(echo .)vnet.ibm.com \
    --cc=mikey@neuling$(echo .)org \
    --cc=npiggin@gmail$(echo .)com \
    --cc=shilpa.bhat@linux$(echo .)vnet.ibm.com \
    --cc=shreyasbp@gmail$(echo .)com \
    --cc=svaidy@linux$(echo .)vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox