From: Michael Ellerman <mpe@ellerman•id.au>
To: Christophe Leroy <christophe.leroy@c-s•fr>,
Arnd Bergmann <arnd@arndb•de>
Cc: linuxppc-dev <linuxppc-dev@lists•ozlabs.org>,
Paul Mackerras <paulus@samba•org>,
Michal Simek <michal.simek@xilinx•com>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>
Subject: Re: [PATCH v2 09/11] powerpc/platforms: Move files from 4xx to 44x
Date: Wed, 01 Apr 2020 13:20:21 +1100 [thread overview]
Message-ID: <87d08sueu2.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <74e76b4e-5e4f-f3de-96a8-f6a451b3243a@c-s.fr>
Christophe Leroy <christophe.leroy@c-s•fr> writes:
> Le 31/03/2020 à 18:04, Arnd Bergmann a écrit :
>> On Tue, Mar 31, 2020 at 5:26 PM Christophe Leroy
>> <christophe.leroy@c-s•fr> wrote:
>>> Le 31/03/2020 à 17:14, Arnd Bergmann a écrit :
>>>> On Tue, Mar 31, 2020 at 9:49 AM Christophe Leroy
>>>> <christophe.leroy@c-s•fr> wrote:
>>>>>
>>>>> Only 44x uses 4xx now, so only keep one directory.
>>>>>
>>>>> Signed-off-by: Christophe Leroy <christophe.leroy@c-s•fr>
>>>>> ---
>>>>> arch/powerpc/platforms/44x/Makefile | 9 +++++++-
>>>>> arch/powerpc/platforms/{4xx => 44x}/cpm.c | 0
>>>>
>>>> No objections to moving everything into one place, but I wonder if the
>>>> combined name should be 4xx instead of 44x, given that 44x currently
>>>> include 46x and 47x. OTOH your approach has the advantage of
>>>> moving fewer files.
>>>>
>>>
>>> In that case, should we also rename CONFIG_44x to CONFIG_4xx ?
>>
>> That has the risk of breaking user's defconfig files, but given the
>> small number of users, it may be nicer for consistency. In either
>> case, the two symbols should probably hang around as synonyms,
>> the question is just which one is user visible.
>>
>
> Not sure it is a good idea to keep two synonyms. In the past we made our
> best to remove synonyms (We had CONFIG_8xx and CONFIG_PPC_8xx being
> synonyms, we had CONFIG_6xx and CONFIG_BOOK3S_32 and
> CONFIG_PPC_STD_MMU_32 being synonyms).
> I think it is a lot cleaner when we can avoid synonyms.
>
> By the way I already dropped CONFIG_4xx in previous patch (8/11). It was
> not many 4xx changed to 44x. It would be a lot more in the other way
> round I'm afraid.
>
> But I agree with you it might be more natural to change to 4xx.
>
> Michael, any preference ?
I'd say just use 44x, we've had the inconsistency of 476 living in
platforms/44x, and it hasn't really led to much confusion.
I think for most folks they see 4xx/44x and just think "some 32-bit
embedded thing", so the precise distinction between 4xx, 44x, 476 etc.
is not that important to justify renaming the symbol everywhere I think.
cheers
next prev parent reply other threads:[~2020-04-01 2:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 7:49 [PATCH v2 01/11] powerpc: Mark 4xx as Orphan in MAINTAINERS Christophe Leroy
2020-03-31 7:49 ` [PATCH v2 02/11] powerpc: Remove Xilinx PPC405/PPC440 support Christophe Leroy
2020-03-31 7:49 ` [PATCH v2 03/11] powerpc/40x: Remove 40x platforms Christophe Leroy
2020-03-31 7:49 ` [PATCH v2 04/11] powerpc/boot: Remove all " Christophe Leroy
2020-03-31 7:49 ` [PATCH v2 05/11] powerpc: Remove support for 40x Christophe Leroy
2020-03-31 7:49 ` [PATCH v2 06/11] powerpc: Remove IBM405 Erratum #77 Christophe Leroy
2020-03-31 7:49 ` [PATCH v2 07/11] powerpc/xmon: Remove PPC403 and PPC405 Christophe Leroy
2020-03-31 15:10 ` Arnd Bergmann
2020-04-01 2:16 ` Michael Ellerman
2020-03-31 7:49 ` [PATCH v2 08/11] powerpc/4xx: Remove CONFIG_4xx Christophe Leroy
2020-03-31 7:49 ` [PATCH v2 09/11] powerpc/platforms: Move files from 4xx to 44x Christophe Leroy
2020-03-31 15:14 ` Arnd Bergmann
2020-03-31 15:26 ` Christophe Leroy
2020-03-31 16:04 ` Arnd Bergmann
2020-03-31 16:19 ` Christophe Leroy
2020-03-31 18:38 ` Arnd Bergmann
2020-04-01 2:20 ` Michael Ellerman [this message]
2020-03-31 7:49 ` [PATCH v2 10/11] powerpc/pgtable: Drop PTE_ATOMIC_UPDATES Christophe Leroy
2020-03-31 7:49 ` [PATCH v2 11/11] powerpc/32: Replace RFI by rfi Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d08sueu2.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=arnd@arndb$(echo .)de \
--cc=christophe.leroy@c-s$(echo .)fr \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=michal.simek@xilinx$(echo .)com \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox