From: Kalle Valo <kvalo@codeaurora•org>
To: Krzysztof Kozlowski <krzk@kernel•org>
Cc: Rich Felker <dalias@libc•org>, Jiri Slaby <jirislaby@gmail•com>,
Geert Uytterhoeven <geert+renesas@glider•be>,
"Michael S. Tsirkin" <mst@redhat•com>,
David Airlie <airlied@linux•ie>, Jason Wang <jasowang@redhat•com>,
dri-devel@lists•freedesktop.org,
virtualization@lists•linux-foundation.org,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership•com>,
netdev@vger•kernel.org, Paul Mackerras <paulus@samba•org>,
linux-arch@vger•kernel.org, Dave Jiang <dave.jiang@intel•com>,
Yoshinori Sato <ysato@users•sourceforge.jp>,
Helge Deller <deller@gmx•de>,
linux-sh@vger•kernel.org, Alexey Brodkin <abrodkin@synopsys•com>,
Ben Skeggs <bskeggs@redhat•com>,
nouveau@lists•freedesktop.org, Dave Airlie <airlied@redhat•com>,
Matt Turner <mattst88@gmail•com>,
linux-snps-arc@lists•infradead.org,
Nick Kossifidis <mickflemm@gmail•com>,
Allen Hubbe <allenbh@gmail•com>, Arnd Bergmann <arnd@arndb•de>,
linux-alpha@vger•kernel.org,
Ivan Kokshaysky <ink@jurassic•park.msu.ru>,
Thomas Gleixner <tglx@linutronix•de>,
Mauro Carvalho Chehab <mchehab@kernel•org>,
Richard Henderson <rth@twiddle•net>,
linux-parisc@vger•kernel.org, Vineet Gupta <vgupta@synopsys•com>,
linux-wireless@vger•kernel.org, linux-kernel@vger•kernel.org,
Luis Chamberlain <mcgrof@kernel•org>,
Daniel Vetter <daniel@ffwll•ch>, Jon Mason <jdmason@kudzu•us>,
linux-ntb@googlegroups•com, linux-media@vger•kernel.org,
linuxppc-dev@lists•ozlabs.org,
"David S. Miller" <davem@davemloft•net>
Subject: Re: [PATCH v2 9/9] net: wireless: ath5k: Constify ioreadX() iomem argument (as in generic implementation)
Date: Fri, 10 Jan 2020 15:33:11 +0200 [thread overview]
Message-ID: <87eew7sag8.fsf@codeaurora.org> (raw)
In-Reply-To: <20200108200528.4614-10-krzk@kernel.org> (Krzysztof Kozlowski's message of "Wed, 8 Jan 2020 21:05:28 +0100")
Krzysztof Kozlowski <krzk@kernel•org> writes:
> The ioreadX() helpers have inconsistent interface. On some architectures
> void *__iomem address argument is a pointer to const, on some not.
>
> Implementations of ioreadX() do not modify the memory under the address
> so they can be converted to a "const" version for const-safety and
> consistency among architectures.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel•org>
> ---
> drivers/net/wireless/ath/ath5k/ahb.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
No need to have "net: wireless: " in the title, otherwise looks good.
Acked-by: Kalle Valo <kvalo@codeaurora•org>
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2020-01-10 13:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 20:05 [PATCH v2 0/9] iomap: Constify ioreadX() iomem argument Krzysztof Kozlowski
2020-01-08 20:05 ` [PATCH v2 1/9] iomap: Constify ioreadX() iomem argument (as in generic implementation) Krzysztof Kozlowski
2020-01-08 20:53 ` Arnd Bergmann
2020-01-09 12:00 ` Geert Uytterhoeven
2020-01-08 20:05 ` [PATCH v2 2/9] net: wireless: rtl818x: " Krzysztof Kozlowski
2020-01-10 13:32 ` Kalle Valo
2020-01-26 15:11 ` Kalle Valo
2020-01-08 20:05 ` [PATCH v2 3/9] ntb: intel: " Krzysztof Kozlowski
2020-01-08 20:29 ` Dave Jiang
2020-01-08 20:05 ` [PATCH v2 4/9] virtio: pci: " Krzysztof Kozlowski
2020-01-08 20:05 ` [PATCH v2 5/9] arc: " Krzysztof Kozlowski
2020-01-09 6:59 ` Alexey Brodkin
2020-01-08 20:05 ` [PATCH v2 6/9] drm/mgag200: " Krzysztof Kozlowski
2020-01-09 6:04 ` Thomas Zimmermann
2020-01-08 20:05 ` [PATCH v2 7/9] drm/nouveau: " Krzysztof Kozlowski
2020-01-08 20:05 ` [PATCH v2 8/9] media: fsl-viu: " Krzysztof Kozlowski
2020-01-08 20:05 ` [PATCH v2 9/9] net: wireless: ath5k: " Krzysztof Kozlowski
2020-01-10 13:33 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eew7sag8.fsf@codeaurora.org \
--to=kvalo@codeaurora$(echo .)org \
--cc=James.Bottomley@HansenPartnership$(echo .)com \
--cc=abrodkin@synopsys$(echo .)com \
--cc=airlied@linux$(echo .)ie \
--cc=airlied@redhat$(echo .)com \
--cc=allenbh@gmail$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=bskeggs@redhat$(echo .)com \
--cc=dalias@libc$(echo .)org \
--cc=daniel@ffwll$(echo .)ch \
--cc=dave.jiang@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=deller@gmx$(echo .)de \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=geert+renesas@glider$(echo .)be \
--cc=ink@jurassic$(echo .)park.msu.ru \
--cc=jasowang@redhat$(echo .)com \
--cc=jdmason@kudzu$(echo .)us \
--cc=jirislaby@gmail$(echo .)com \
--cc=krzk@kernel$(echo .)org \
--cc=linux-alpha@vger$(echo .)kernel.org \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-ntb@googlegroups$(echo .)com \
--cc=linux-parisc@vger$(echo .)kernel.org \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=linux-snps-arc@lists$(echo .)infradead.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mattst88@gmail$(echo .)com \
--cc=mcgrof@kernel$(echo .)org \
--cc=mchehab@kernel$(echo .)org \
--cc=mickflemm@gmail$(echo .)com \
--cc=mst@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nouveau@lists$(echo .)freedesktop.org \
--cc=paulus@samba$(echo .)org \
--cc=rth@twiddle$(echo .)net \
--cc=tglx@linutronix$(echo .)de \
--cc=vgupta@synopsys$(echo .)com \
--cc=virtualization@lists$(echo .)linux-foundation.org \
--cc=ysato@users$(echo .)sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox