Subject: Re: [PATCH v3 1/3] powerpc/pseries: Update SCM hcall op-codes in hvcall.h

From: Vaibhav Jain <[email-masked]>
Date: Sat, 29 Jun 2019 21:39:18 +0530

Thanks for reviewing this patch Mpe.

Michael Ellerman <[email-masked]> writes:

> "Oliver O'Halloran" <[email-masked]> writes:
>> On Fri, Jun 28, 2019 at 1:39 PM Michael Ellerman <[email-masked]> wrote:
>>>
>>> Vaibhav Jain <[email-masked]> writes:
>>> > *snip*
>>>
>>> How can we be changing the meaning of HCALL numbers without breaking all
>>> existing usages?
>>
>> The changed one being changed here were never used by linux or
>> implemented by either hypervisor.
>
> OK. Please say so in the change log so that it's clear it's not a
> behaviour change.
I have respinned this patchset to v4 updating this patch's
description mentioning the hcall opcodes that are removed.

>
>>> Where are these hypervisor calls documented?
>>
>> In an internal spec from one the phyp guys. I have been complaining
>> about it not being open (or merged into PAPR at the very least), but
>> it doesn't look like there's been any movement there.
>
> Please send a patch for Documentation/powerpc/ describing the API for
> the hypercalls we're using.
Sure will send a separate patch documenting this.

> cheers

-- 
Vaibhav Jain <[email-masked]>
Linux Technology Center, IBM India Pvt. Ltd.