public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: "Aneesh Kumar K.V" <aneesh.kumar@linux•vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman•id.au>,
	Benjamin Herrenschmidt <benh@kernel•crashing.org>,
	Denis Kirjanov <kda@linux-powerpc•org>
Cc: linuxppc-dev <linuxppc-dev@lists•ozlabs.org>
Subject: Re: unrecoverable exception on G5 with CONFIG_PPC_EARLY_DEBUG enabled
Date: Sat, 18 Jun 2016 22:47:18 +0530	[thread overview]
Message-ID: <87eg7u8li9.fsf@skywalker.in.ibm.com> (raw)
In-Reply-To: <1466127964.12899.5.camel@ellerman.id.au>

Michael Ellerman <mpe@ellerman•id.au> writes:

> On Fri, 2016-06-17 at 08:33 +1000, Benjamin Herrenschmidt wrote:
>> On Thu, 2016-06-16 at 22:49 +0300, Denis Kirjanov wrote:
>> > -
>> > +BEGIN_MMU_FTR_SECTION
>> > +       b       2f
>> > +END_MMU_FTR_SECTION_IFSET(MMU_FTR_RADIX)
>> >         andi.   r10,r12,MSR_RI  /* check for unrecoverable exception
>> > */
>> >         beq-    2f
>> 
>> Are we taking an SLB miss before we do the fixup maybe ?
>
> Yeah that's the only explanation that makes any sense.
>
> I think instead of patching down this low we should instead be redirecting SLB
> misses to unknown_exception() when radix is enabled. Aneesh?
>

The 2f branch ends up doing unrecoverable exception. Or are you
suggesting something else ?

-aneesh

  reply	other threads:[~2016-06-18 17:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-06  7:52 unrecoverable exception on G5 with CONFIG_PPC_EARLY_DEBUG enabled Denis Kirjanov
2016-06-06 12:27 ` Michael Ellerman
2016-06-16  8:12   ` Denis Kirjanov
2016-06-16 12:07     ` Michael Ellerman
2016-06-16 19:49       ` Denis Kirjanov
2016-06-16 22:33         ` Benjamin Herrenschmidt
2016-06-17  1:46           ` Michael Ellerman
2016-06-18 17:17             ` Aneesh Kumar K.V [this message]
2016-06-20  9:23               ` Michael Ellerman
2016-06-20 10:21                 ` Aneesh Kumar K.V
2016-06-21  0:59                   ` Michael Ellerman
2016-06-21  4:23                 ` Denis Kirjanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eg7u8li9.fsf@skywalker.in.ibm.com \
    --to=aneesh.kumar@linux$(echo .)vnet.ibm.com \
    --cc=benh@kernel$(echo .)crashing.org \
    --cc=kda@linux-powerpc$(echo .)org \
    --cc=linuxppc-dev@lists$(echo .)ozlabs.org \
    --cc=mpe@ellerman$(echo .)id.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox