From: Peter Korsgaard <jacmet@sunsite•dk>
To: Jon Smirl <jonsmirl@gmail•com>
Cc: linuxppc-dev@ozlabs•org, alsa-devel@alsa-project•org,
broonie@sirena•org.uk
Subject: Re: [PATCH V3 4/4] Fabric bindings for STAC9766 on the Efika
Date: Thu, 28 May 2009 16:00:20 +0200 [thread overview]
Message-ID: <87eiu972ff.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20090525013853.3073.78627.stgit@terra> (Jon Smirl's message of "Sun\, 24 May 2009 21\:38\:53 -0400")
>>>>> "Jon" == Jon Smirl <jonsmirl@gmail•com> writes:
Hi,
Jon> Fabric bindings for STAC9766 AC97 codec on the Efika.
Jon> Signed-off-by: Jon Smirl <jonsmirl@gmail•com>
Jon> ---
Jon> sound/soc/fsl/Kconfig | 8 +++
Jon> sound/soc/fsl/Makefile | 1
Jon> sound/soc/fsl/efika-audio-fabric.c | 95 ++++++++++++++++++++++++++++++++++++
Jon> 3 files changed, 104 insertions(+), 0 deletions(-)
Jon> create mode 100644 sound/soc/fsl/efika-audio-fabric.c
Jon> diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
Jon> index 79579ae..f571c6e 100644
Jon> --- a/sound/soc/fsl/Kconfig
Jon> +++ b/sound/soc/fsl/Kconfig
Jon> @@ -47,3 +47,11 @@ config SND_MPC52xx_SOC_PCM030
Jon> help
Jon> Say Y if you want to add support for sound on the Phytec pcm030 baseboard.
Jon> +config SND_MPC52xx_SOC_EFIKA
Jon> + tristate "SoC AC97 Audio support for bbplan Efika and STAC9766"
Jon> + depends on PPC_EFIKA
Jon> + select SND_SOC_MPC5200_AC97
Jon> + select SND_SOC_STAC9766
Jon> + help
Jon> + Say Y if you want to add support for sound on the Efika.
Jon> +
Wouldn't it make more sense to make this default y when it has such
specific dependencies and is so deep down in the tree - Most efika
users probably want to enable this if they have enabled ALSA and
SND_SOC?
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2009-05-28 14:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-25 1:38 [PATCH V3 0/4] mpc5200 audio rework for AC97 Jon Smirl
2009-05-25 1:38 ` [PATCH V3 1/4] Main rewite of the mpc5200 audio DMA code Jon Smirl
2009-05-25 6:26 ` Grant Likely
2009-05-25 9:34 ` Mark Brown
2009-05-25 13:22 ` Grant Likely
2009-05-25 1:38 ` [PATCH V3 2/4] AC97 driver for mpc5200 Jon Smirl
2009-05-25 6:16 ` Grant Likely
2009-05-25 15:15 ` Jon Smirl
2009-05-25 15:22 ` Mark Brown
2009-05-25 15:59 ` Grant Likely
2009-05-25 10:26 ` Mark Brown
2009-05-25 15:21 ` Jon Smirl
2009-05-25 16:00 ` Grant Likely
2009-05-25 1:38 ` [PATCH V3 3/4] Support for AC97 on Phytec pmc030 base board Jon Smirl
2009-05-25 6:34 ` Grant Likely
2009-05-25 9:46 ` Mark Brown
2009-05-25 14:39 ` Jon Smirl
2009-05-25 9:48 ` Mark Brown
2009-05-25 1:38 ` [PATCH V3 4/4] Fabric bindings for STAC9766 on the Efika Jon Smirl
2009-05-28 14:00 ` Peter Korsgaard [this message]
2009-05-28 18:58 ` Jon Smirl
2009-05-25 10:43 ` [PATCH V3 0/4] mpc5200 audio rework for AC97 Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eiu972ff.fsf@macbook.be.48ers.dk \
--to=jacmet@sunsite$(echo .)dk \
--cc=alsa-devel@alsa-project$(echo .)org \
--cc=broonie@sirena$(echo .)org.uk \
--cc=jonsmirl@gmail$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox