From: Peter Korsgaard <jacmet@sunsite•dk>
To: avorontsov@ru•mvista.com
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH v2] powerpc: implement support for MPC8349-compatible SOC GPIOs
Date: Fri, 19 Sep 2008 17:11:15 +0200 [thread overview]
Message-ID: <87ej3gyxv0.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20080918112020.GA11584@oksana.dev.rtsoft.ru> (Anton Vorontsov's message of "Thu\, 18 Sep 2008 15\:20\:20 +0400")
>>>>> "Anton" == Anton Vorontsov <avorontsov@ru•mvista.com> writes:
Hi,
>> It seems basically the same as my patch (gpio driver for
>> mpc831x/mpc834x/mpc837x with OF bindings) from September 5th except
>> you don't have any documentation
Anton> Well, do we really need documentation for every trivial gpio
Anton> controller? The bindings are the same, only different compatible
Anton> entries...
Well, we need some way of knowing that atleast. Having people grepping
through arch/powerpc/boot/dts/ (and knowing that they should look for
8349 even though they might use 8313 or 8610) doesn't seem optimal to
me - I take it that's why we created
Documentation/powerpc/dts-bindings in the first place?
Anton> If we do need the documentation for this, I can readily include it.
>> and the Kconfig doesn't depend on
>> 831x/834x/837x.
Anton> This is purposely. We also need support for 8610, and maybe
Anton> later we'll find another chip with the same unit. So, to not touch
Anton> the Kconfig for every new chip I just made it PPC32-wide. Other
Anton> option is to depend on FSL_SOC, but the driver really does not
Anton> depend on any fsl_soc stuff...
Adding another symbol to the Kconfig once it is verified that a new
SoC is compatible doesn't seem like a big deal - Figuring out all the
knobs we already have is, without having options for stuff that is
known to be irrelevant for the SoC.
The other 83xx specific drivers also depend on PPC_83xx.
>> Why do you need this when you have the lock?
Anton> See this discussion:
Anton> http://www.mail-archive.com/linuxppc-dev@ozlabs.org/msg12299.html
Ahh, for open drain outputs. gpiolib doesn't actually provide an
interface to put the gpios in that mode, but it could ofcause have
been set up in the bootloader. I'll fix that and send an updated
patch.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2008-09-19 15:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-17 17:58 [PATCH v2] powerpc: implement support for MPC8349-compatible SOC GPIOs Anton Vorontsov
2008-09-17 19:30 ` Peter Korsgaard
2008-09-18 11:20 ` Anton Vorontsov
2008-09-19 15:11 ` Peter Korsgaard [this message]
2008-09-19 15:33 ` Anton Vorontsov
2008-09-19 18:02 ` Kumar Gala
2008-09-19 18:12 ` Anton Vorontsov
2008-09-19 18:46 ` Kumar Gala
2008-09-21 19:30 ` Peter Korsgaard
2008-09-25 16:41 ` Scott Wood
2008-09-25 16:43 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ej3gyxv0.fsf@macbook.be.48ers.dk \
--to=jacmet@sunsite$(echo .)dk \
--cc=avorontsov@ru$(echo .)mvista.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox