From: Michael Ellerman <mpe@ellerman•id.au>
To: Geoff Levand <geoff@infradead•org>,
Christophe Leroy <christophe.leroy@csgroup•eu>
Cc: "linuxppc-dev@lists•ozlabs.org" <linuxppc-dev@lists•ozlabs.org>
Subject: Re: [PATCH v2 1/2] powerpc/ps3: Change updateboltedpp panic to info
Date: Fri, 10 Feb 2023 11:51:38 +1100 [thread overview]
Message-ID: <87fsbewdet.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <38e58d03-3142-72ae-7424-696499a99bb2@infradead.org>
Geoff Levand <geoff@infradead•org> writes:
> On 1/16/23 23:26, Christophe Leroy wrote:
>> Le 16/01/2023 à 21:08, Geoff Levand a écrit :
>>>
>>> As mentioned, I'd really like to keep PS3 included in ppc64_defconfig. My
>>> original patch that basically just ignores the call to
>>> mmu_hash_ops.updateboltedpp allows that, and I haven't experienced any problems
>>> with it yet.
>>
>> When you say you have not experienced any problems with it, do you mean
>> that STRICT_RWX works for you ? When you select CONFIG_DEBUG_RODATA_TEST
>> it tells you that it works ? Otherwise it looks incorrect to enable
>> something that doesn't work.
>
> What I mean is that the system boots up, and works as expected.
> I have not tried with CONFIG_DEBUG_RODATA_TEST set.
>
>>> My preference would be to keep PS3 in ppc64_defconfig, and either apply my
>>> original patch, or I keep that patch in my ps3-linux repo on kernel.org. Then,
>>> if we end up adding runtime support for RWX I then fixup PS3 to use that.
>>>
>>
>> In that case I see two solutions:
>> 1/ Implement updateboltedpp for PS3.
>
> I'm now looking into if this is possible.
>
>> 2/ Implement arch_parse_debug_rodata() to always set rodata_enabled =
>> false on PS3, and update free_initmem() to only call mark_initmem_nx()
>> when strict_kernel_rwx_enabled() returns true.
>
> OK, I'll consider this if I cannot get updateboltedp working.
I'll take this series as-is for 6.3, there's no point panicking.
Hopefully one of the above options can be implemented in future.
cheers
next prev parent reply other threads:[~2023-02-10 0:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 17:51 [PATCH v2 0/2] PS3 patches Geoff Levand
2023-01-03 17:51 ` [PATCH v2 1/2] powerpc/ps3: Change updateboltedpp panic to info Geoff Levand
2023-01-09 17:41 ` Christophe Leroy
2023-01-14 21:22 ` Geoff Levand
2023-01-16 0:06 ` Michael Ellerman
2023-01-16 20:08 ` Geoff Levand
2023-01-17 7:26 ` Christophe Leroy
2023-01-28 22:45 ` Geoff Levand
2023-02-10 0:51 ` Michael Ellerman [this message]
2023-01-03 17:51 ` [PATCH v2 2/2] powerpc/ps3: Refresh ps3_defconfig Geoff Levand
2023-02-15 12:41 ` [PATCH v2 0/2] PS3 patches Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsbewdet.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=christophe.leroy@csgroup$(echo .)eu \
--cc=geoff@infradead$(echo .)org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox