From: Michael Ellerman <mpe@ellerman•id.au>
To: Andy Shevchenko <andy.shevchenko@gmail•com>, "Enrico Weigelt\,
metux IT consult" <info@metux•net>
Cc: Mark Rutland <mark.rutland@arm•com>,
Rich Felker <dalias@libc•org>,
linux-ia64@vger•kernel.org, Linux-SH <linux-sh@vger•kernel.org>,
Alexander Shishkin <alexander.shishkin@linux•intel.com>,
Linus Walleij <linus.walleij@linaro•org>,
linux-mips@vger•kernel.org,
James Bottomley <James.Bottomley@hansenpartnership•com>,
Paul Mackerras <paulus@samba•org>,
"H. Peter Anvin" <hpa@zytor•com>,
sparclinux@vger•kernel.org, Will Deacon <will@kernel•org>,
gerg@linux-m68k•org, Linux-Arch <linux-arch@vger•kernel.org>,
linux-s390@vger•kernel.org, linux-c6x-dev@linux-c6x•org,
Yoshinori Sato <ysato@users•sourceforge.jp>,
Jiri Olsa <jolsa@redhat•com>, Helge Deller <deller@gmx•de>,
"maintainer:X86 ARCHITECTURE \(32-BIT AND 64-BIT\)"
<x86@kernel•org>, Bartosz Golaszewski <bgolaszewski@baylibre•com>,
Tony Lindgren <tony@atomide•com>,
Geert Uytterhoeven <geert@linux-m68k•org>,
Catalin Marinas <catalin.marinas@arm•com>,
linux-alpha@vger•kernel.org, Arnd Bergmann <arnd@arndb•de>,
msalter@redhat•com, jacquiot.aurelien@gmail•com,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger•kernel.org>,
linux-m68k@lists•linux-m68k.org, Borislav Petkov <bp@alien8•de>,
Namhyung Kim <namhyung@kernel•org>,
Thomas Gleixner <tglx@linutronix•de>,
Linux OMAP Mailing List <linux-omap@vger•kernel.org>,
Thomas Bogendoerfer <tsbogend@alpha•franken.de>,
linux-parisc@vger•kernel.org,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Marc Zyngier <maz@kernel•org>,
"open list:LINUX FOR POWERPC PA SEMI PWRFICIENT"
<linuxppc-dev@lists•ozlabs.org>,
"David S. Miller" <davem@davemloft•net>
Subject: Re: [PATCH 01/23] kernel: irq: irqdescs: warn on spurious IRQ
Date: Mon, 21 Dec 2020 16:44:13 +1100 [thread overview]
Message-ID: <87ft3zyaqa.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <CAHp75VfYz_K2BYOxqmSx0q+1F2F9Lp1eb70RrNYzJHs3FX+quQ@mail.gmail.com>
Andy Shevchenko <andy.shevchenko@gmail•com> writes:
> On Fri, Dec 18, 2020 at 4:37 PM Enrico Weigelt, metux IT consult
> <info@metux•net> wrote:
>
>> + if (printk_ratelimit())
>> + pr_warn("spurious IRQ: irq=%d hwirq=%d nr_irqs=%d\n",
>> + irq, hwirq, nr_irqs);
>
> Perhaps you missed pr_warn_ratelimit() macro which is already in the
> kernel for a long time.
pr_warn_ratelimited() which calls printk_ratelimited().
And see the comment above printk_ratelimit():
/*
* Please don't use printk_ratelimit(), because it shares ratelimiting state
* with all other unrelated printk_ratelimit() callsites. Instead use
* printk_ratelimited() or plain old __ratelimit().
*/
cheers
next prev parent reply other threads:[~2020-12-21 5:46 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-18 14:30 cleanup handling of bad IRQs Enrico Weigelt, metux IT consult
2020-12-18 14:31 ` [PATCH 01/23] kernel: irq: irqdescs: warn on spurious IRQ Enrico Weigelt, metux IT consult
2020-12-18 15:55 ` Andy Shevchenko
2020-12-21 5:44 ` Michael Ellerman [this message]
2020-12-21 9:27 ` Andy Shevchenko
2020-12-18 14:31 ` [PATCH 02/23] arch: alpha: drop misleading warning " Enrico Weigelt, metux IT consult
2020-12-18 14:31 ` [PATCH 03/23] arch: arm: " Enrico Weigelt, metux IT consult
2020-12-18 14:31 ` [PATCH 04/23] arch: c6x: " Enrico Weigelt, metux IT consult
2020-12-18 14:31 ` [PATCH 05/23] arch: ia64: " Enrico Weigelt, metux IT consult
2020-12-18 14:31 ` [PATCH 06/23] arch: mips: " Enrico Weigelt, metux IT consult
2020-12-18 14:31 ` [PATCH 07/23] arch: parisc: " Enrico Weigelt, metux IT consult
2020-12-18 14:31 ` [PATCH 08/23] arch: powerpc: " Enrico Weigelt, metux IT consult
2020-12-18 14:31 ` [PATCH 09/23] arch: s390: " Enrico Weigelt, metux IT consult
2020-12-18 14:31 ` [PATCH 10/23] arch: sh: " Enrico Weigelt, metux IT consult
2020-12-18 14:31 ` [PATCH 11/23] arch: sparc: " Enrico Weigelt, metux IT consult
2020-12-18 14:31 ` [PATCH 12/23] arch: x86: " Enrico Weigelt, metux IT consult
2020-12-18 14:31 ` [PATCH 13/23] arch: generic: " Enrico Weigelt, metux IT consult
2020-12-18 14:31 ` [PATCH 14/23] kernel: generic counter for interrupt errors Enrico Weigelt, metux IT consult
2020-12-18 14:31 ` [PATCH 15/23] arch: mips: use generic irq error counter Enrico Weigelt, metux IT consult
2020-12-18 14:31 ` [PATCH 16/23] arch: alpha: " Enrico Weigelt, metux IT consult
2020-12-18 14:31 ` [PATCH 17/23] arch: arm: " Enrico Weigelt, metux IT consult
2020-12-18 14:31 ` [PATCH 18/23] arch: arm64: " Enrico Weigelt, metux IT consult
2020-12-18 14:31 ` [PATCH 19/23] arch: c6x: " Enrico Weigelt, metux IT consult
-- strict thread matches above, loose matches on Subject: below --
2020-12-18 14:57 (repost) cleaning up handling of bad IRQs Enrico Weigelt, metux IT consult
2020-12-18 14:57 ` [PATCH 01/23] kernel: irq: irqdescs: warn on spurious IRQ Enrico Weigelt, metux IT consult
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ft3zyaqa.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=James.Bottomley@hansenpartnership$(echo .)com \
--cc=alexander.shishkin@linux$(echo .)intel.com \
--cc=andy.shevchenko@gmail$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=bgolaszewski@baylibre$(echo .)com \
--cc=bp@alien8$(echo .)de \
--cc=catalin.marinas@arm$(echo .)com \
--cc=dalias@libc$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=deller@gmx$(echo .)de \
--cc=geert@linux-m68k$(echo .)org \
--cc=gerg@linux-m68k$(echo .)org \
--cc=hpa@zytor$(echo .)com \
--cc=info@metux$(echo .)net \
--cc=jacquiot.aurelien@gmail$(echo .)com \
--cc=jolsa@redhat$(echo .)com \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-alpha@vger$(echo .)kernel.org \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-c6x-dev@linux-c6x$(echo .)org \
--cc=linux-gpio@vger$(echo .)kernel.org \
--cc=linux-ia64@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-m68k@lists$(echo .)linux-m68k.org \
--cc=linux-mips@vger$(echo .)kernel.org \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=linux-parisc@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=maz@kernel$(echo .)org \
--cc=msalter@redhat$(echo .)com \
--cc=namhyung@kernel$(echo .)org \
--cc=paulus@samba$(echo .)org \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=tglx@linutronix$(echo .)de \
--cc=tony@atomide$(echo .)com \
--cc=tsbogend@alpha$(echo .)franken.de \
--cc=will@kernel$(echo .)org \
--cc=x86@kernel$(echo .)org \
--cc=ysato@users$(echo .)sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox