From: Michael Ellerman <mpe@ellerman•id.au>
To: Pedro Franco de Carvalho <pedromfc@linux•vnet.ibm.com>,
linuxppc-dev@lists•ozlabs.org,
Anshuman Khandual <khandual@linux•vnet.ibm.com>
Subject: Re: [RFC PATCH 1/5] powerpc: Fix inverted active predicate for setting the EBB regset
Date: Wed, 13 Jun 2018 12:15:04 +1000 [thread overview]
Message-ID: <87fu1rtot3.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20180607152534.29427-2-pedromfc@linux.vnet.ibm.com>
Pedro Franco de Carvalho <pedromfc@linux•vnet.ibm.com> writes:
> Currently, the ebb_set function for writing to the EBB regset returns
> ENODATA when ebb is active in the thread, and copies in the data when
> it is inactive. This patch inverts the condition so that it matches
> ebb_get and ebb_active.
> ---
> arch/powerpc/kernel/ptrace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Hi Pedro,
Thanks for looking into this, how did you detect this? Do you have a
test case?
I don't think Anshuman wrote it this way on purpose, but added him to Cc
in case he remembers.
But I don't think this fix is necessarily right. If we are setting the
EBB regs via ptrace then it doesn't matter if they were previously in
use or not, we should just set them. What *does* matter is that at the
end of the function we set used_ebb to true, because otherwise the
values we have set will not actually be used when the process is
rescheduled.
cheers
> diff --git a/arch/powerpc/kernel/ptrace.c b/arch/powerpc/kernel/ptrace.c
> index d23cf632edf0..6618570c6d56 100644
> --- a/arch/powerpc/kernel/ptrace.c
> +++ b/arch/powerpc/kernel/ptrace.c
> @@ -1701,7 +1701,7 @@ static int ebb_set(struct task_struct *target,
> if (!cpu_has_feature(CPU_FTR_ARCH_207S))
> return -ENODEV;
>
> - if (target->thread.used_ebb)
> + if (!target->thread.used_ebb)
> return -ENODATA;
>
> ret = user_regset_copyin(&pos, &count, &kbuf, &ubuf,
> --
> 2.13.6
next prev parent reply other threads:[~2018-06-13 2:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-07 15:25 [RFC PATCH 0/5] powerpc: Misc. ptrace regset fixes Pedro Franco de Carvalho
2018-06-07 15:25 ` [RFC PATCH 1/5] powerpc: Fix inverted active predicate for setting the EBB regset Pedro Franco de Carvalho
2018-06-13 2:15 ` Michael Ellerman [this message]
2018-06-13 4:09 ` Michael Ellerman
2018-06-14 13:52 ` Pedro Franco de Carvalho
2018-06-07 15:25 ` [RFC PATCH 2/5] powerpc: Flush checkpointed gpr state for 32-bit processes in ptrace Pedro Franco de Carvalho
2018-06-13 2:19 ` Michael Ellerman
2018-06-14 13:55 ` Pedro Franco de Carvalho
2018-06-19 19:54 ` [PATCH 1/2] " Pedro Franco de Carvalho
2024-03-12 8:07 ` Christophe Leroy
2018-06-19 19:54 ` [PATCH 2/2] powerpc: Use helper function to flush TM state " Pedro Franco de Carvalho
2018-06-07 15:25 ` [RFC PATCH 3/5] powerpc: Fix pmu get/set functions Pedro Franco de Carvalho
2018-06-07 15:25 ` [RFC PATCH 4/5] powerpc: Add VSX regset to compat_regsets Pedro Franco de Carvalho
2018-06-07 15:25 ` [RFC PATCH 5/5] powerpc: Add PMU " Pedro Franco de Carvalho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fu1rtot3.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=khandual@linux$(echo .)vnet.ibm.com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=pedromfc@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox