From: Michael Ellerman <mpe@ellerman•id.au>
To: Daniel Axtens <dja@axtens•net>,
Matt Brown <matthew.brown.dev@gmail•com>,
linuxppc-dev@lists•ozlabs.org
Subject: Re: [v5 1/2] lib/raid6: Build proper files on corresponding arch
Date: Wed, 02 Aug 2017 12:00:53 +1000 [thread overview]
Message-ID: <87fudasp7u.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <87bmnysz34.fsf@linkitivity.dja.id.au>
Daniel Axtens <dja@axtens•net> writes:
> Hi Matt,
>
>> --- a/lib/raid6/test/Makefile
>> +++ b/lib/raid6/test/Makefile
>> @@ -44,10 +44,12 @@ else ifeq ($(HAS_NEON),yes)
>> CFLAGS += -DCONFIG_KERNEL_MODE_NEON=1
>> else
>> HAS_ALTIVEC := $(shell printf '\#include <altivec.h>\nvector int a;\n' |\
>> - gcc -c -x c - >&/dev/null && \
>> - rm ./-.o && echo yes)
>> + gcc -c -x c - >/dev/null && rm ./-.o && echo yes)
>
> From memory the change here (s/>&/>/) was necessary to get the build to
> succeed - did we ever figure out why that was? I'm not enough of a shell
> guru to grok the difference.
Using >& redirects stdout and stderr, whereas > only redirects stdout.
So possibly it doesn't fix anything, but rather lets you see any error
emitted by the compiler rather than swallowing it?
cheers
next prev parent reply other threads:[~2017-08-02 2:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 5:58 [v5 1/2] lib/raid6: Build proper files on corresponding arch Matt Brown
2017-04-28 5:58 ` [v5 2/2] raid6/altivec: Add vpermxor implementation for raid6 Q syndrome Matt Brown
2017-08-01 23:01 ` Daniel Axtens
2017-08-02 2:04 ` Michael Ellerman
2017-08-02 0:20 ` Daniel Axtens
2017-08-04 1:40 ` Matt Brown
2017-08-01 22:27 ` [v5 1/2] lib/raid6: Build proper files on corresponding arch Daniel Axtens
2017-08-02 2:00 ` Michael Ellerman [this message]
2017-08-04 1:33 ` Matt Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fudasp7u.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=dja@axtens$(echo .)net \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=matthew.brown.dev@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox