From: "Aneesh Kumar K.V" <aneesh.kumar@linux•vnet.ibm.com>
To: Balbir Singh <bsingharora@gmail•com>,
benh@kernel•crashing.org, paulus@samba•org, mpe@ellerman•id.au
Cc: linuxppc-dev@lists•ozlabs.org
Subject: Re: [RFC][PATCH] powerpc/mm: convert tlbie to tlbiel when no batch is active
Date: Mon, 17 Apr 2017 12:37:56 +0530 [thread overview]
Message-ID: <87fuh7h5pv.fsf@skywalker.in.ibm.com> (raw)
In-Reply-To: <20170413051655.26113-1-bsingharora@gmail.com>
Balbir Singh <bsingharora@gmail•com> writes:
> Do the checks that __flush_tlb_pending() does and check if
> a local flush will do when batch->active is false inside of
> hpte_need_flush(). I've checked the changes with tlbie tracing,
> I see local flushes as applicable now and I've also run
> some basic ltp testcases on top of these changes on a powernv
> machine.
>
> Signed-off-by: Balbir Singh <bsingharora@gmail•com>
> ---
> arch/powerpc/mm/tlb_hash64.c | 13 +++++++++----
> 1 file changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/arch/powerpc/mm/tlb_hash64.c b/arch/powerpc/mm/tlb_hash64.c
> index 4517aa4..1268e3a 100644
> --- a/arch/powerpc/mm/tlb_hash64.c
> +++ b/arch/powerpc/mm/tlb_hash64.c
> @@ -93,12 +93,17 @@ void hpte_need_flush(struct mm_struct *mm, unsigned long addr,
>
> /*
> * Check if we have an active batch on this CPU. If not, just
> - * flush now and return. For now, we don global invalidates
> - * in that case, might be worth testing the mm cpu mask though
> - * and decide to use local invalidates instead...
> + * flush now and return.
> */
> if (!batch->active) {
> - flush_hash_page(vpn, rpte, psize, ssize, 0);
> + const struct cpumask *tmp;
> + int local = 0;
> +
> + tmp = cpumask_of(smp_processor_id());
> + if (cpumask_equal(mm_cpumask(mm), tmp))
> + local = 1;
> +
> + flush_hash_page(vpn, rpte, psize, ssize, local);
Can you use mm_is_thread_local(). Also switch similar open coded paths
when doing that ?
> put_cpu_var(ppc64_tlb_batch);
> return;
> }
> --
> 2.9.3
-aneesh
prev parent reply other threads:[~2017-04-17 7:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-13 5:16 [RFC][PATCH] powerpc/mm: convert tlbie to tlbiel when no batch is active Balbir Singh
2017-04-17 7:07 ` Aneesh Kumar K.V [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fuh7h5pv.fsf@skywalker.in.ibm.com \
--to=aneesh.kumar@linux$(echo .)vnet.ibm.com \
--cc=benh@kernel$(echo .)crashing.org \
--cc=bsingharora@gmail$(echo .)com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mpe@ellerman$(echo .)id.au \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox