From: Michael Ellerman <mpe@ellerman•id.au>
To: Nicholas Piggin <npiggin@gmail•com>
Cc: Nicholas Piggin <npiggin@gmail•com>, linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH] powerpc/8xx: xmon compile fix
Date: Wed, 30 Nov 2016 19:00:57 +1100 [thread overview]
Message-ID: <87fum9pfba.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20161129085654.1967-1-npiggin@gmail.com>
Nicholas Piggin <npiggin@gmail•com> writes:
> Signed-off-by: Nicholas Piggin <npiggin@gmail•com>
What's the actual error? mode/badaddr defined but not used?
I'm just curious why I've never hit it?
cheers
> diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c
> index 7605455..435f5f5 100644
> --- a/arch/powerpc/xmon/xmon.c
> +++ b/arch/powerpc/xmon/xmon.c
> @@ -1213,10 +1213,13 @@ bpt_cmds(void)
> {
> int cmd;
> unsigned long a;
> - int mode, i;
> + int i;
> struct bpt *bp;
> +#ifndef CONFIG_8xx
> + int mode;
> const char badaddr[] = "Only kernel addresses are permitted "
> "for breakpoints\n";
> +#endif
>
> cmd = inchar();
> switch (cmd) {
> --
> 2.10.2
next prev parent reply other threads:[~2016-11-30 8:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-29 8:56 [PATCH] powerpc/8xx: xmon compile fix Nicholas Piggin
2016-11-29 9:06 ` Christophe LEROY
2016-11-29 9:53 ` Nicholas Piggin
2016-11-30 8:00 ` Michael Ellerman [this message]
2016-11-30 8:08 ` Nicholas Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fum9pfba.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=npiggin@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox