Subject: Re: [PATCH] powerpc/8xx: xmon compile fix

From: Michael Ellerman <[email-masked]>
Date: Wed, 30 Nov 2016 19:00:57 +1100

Nicholas Piggin <[email-masked]> writes:

> Signed-off-by: Nicholas Piggin <[email-masked]>

What's the actual error? mode/badaddr defined but not used?

I'm just curious why I've never hit it?

cheers

> diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c
> index 7605455..435f5f5 100644
> --- a/arch/powerpc/xmon/xmon.c
> +++ b/arch/powerpc/xmon/xmon.c
> @@ -1213,10 +1213,13 @@ bpt_cmds(void)
>  {
>  	int cmd;
>  	unsigned long a;
> -	int mode, i;
> +	int i;
>  	struct bpt *bp;
> +#ifndef CONFIG_8xx
> +	int mode;
>  	const char badaddr[] = "Only kernel addresses are permitted "
>  		"for breakpoints\n";
> +#endif
>  
>  	cmd = inchar();
>  	switch (cmd) {
> -- 
> 2.10.2