From: Vaibhav Jain <vaibhav@linux•vnet.ibm.com>
To: Michael Neuling <mikey@neuling•org>,
Ian Munsie <imunsie@au1•ibm.com>,
Michael Ellerman <michaele@au1•ibm.com>,
linux-kernel <linux-kernel@vger•kernel.org>,
Matt Ochs <mrochs@us•ibm.com>, Manoj Kumar <kumarmn@us•ibm.com>
Cc: linuxppc-dev <linuxppc-dev@ozlabs•org>
Subject: Re: [PATCH v3 1/2] cxl: Add mechanism for delivering AFU driver specific events
Date: Thu, 10 Mar 2016 22:53:06 +0530 [thread overview]
Message-ID: <87fuvyp7r9.fsf@vajain21.in.ibm.com> (raw)
In-Reply-To: <1457580271.26279.8.camel@neuling.org>
Michael Neuling <mikey@neuling•org> writes:
> These are here to enable the feature in other drivers. So the cxlflash
> (or whoever) can put their code in via the linux-scsi tree but that new
> piece is only enabled when CXL_AFU_DRIVER_OPS is present (ie. when
> merged upstream). But if it's not, their code can still compile.
>
> Hence their code compiles in linux-scsi and our code compiles in linux
> -ppc, but only once they're together do they actually enable the full
> feature. We don't have a nasty dependency of linux-scsi having to pull
> in linux-ppc or visa versa before the merge window. Everyone works
> independently and it all gets fixed in linus tree.
>
> Eventually, when everyone has the all the code in merged upstream, we
> can remove these config options. We should be able to remove
> CXL_KERNEL_API and CXL_EEH now actually!
>
> So no, we shouldn't wrap the actual code.
Mikey & Ian,
Agree on the point made. Thanks for detailed explaination.
~ Vaibhav
prev parent reply other threads:[~2016-03-10 17:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-08 1:48 [PATCH v3 1/2] cxl: Add mechanism for delivering AFU driver specific events Ian Munsie
2016-03-08 1:48 ` [PATCH v3 2/2] cxl: add set/get private data to context struct Ian Munsie
2016-03-08 7:59 ` Andrew Donnellan
2016-03-08 4:06 ` [PATCH v3 1/2] cxl: Add mechanism for delivering AFU driver specific events Matt Ochs
2016-03-08 7:59 ` Andrew Donnellan
2016-03-09 9:27 ` Frederic Barrat
2016-03-10 0:46 ` Ian Munsie
2016-03-10 1:26 ` Ian Munsie
2016-03-09 14:37 ` Vaibhav Jain
2016-03-09 16:41 ` Matt Ochs
2016-03-09 17:08 ` Frederic Barrat
2016-03-10 17:19 ` Vaibhav Jain
2016-03-10 1:18 ` Ian Munsie
2016-03-10 17:39 ` Vaibhav Jain
2016-03-11 1:48 ` Andrew Donnellan
2016-03-10 3:24 ` Michael Neuling
2016-03-10 17:23 ` Vaibhav Jain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fuvyp7r9.fsf@vajain21.in.ibm.com \
--to=vaibhav@linux$(echo .)vnet.ibm.com \
--cc=imunsie@au1$(echo .)ibm.com \
--cc=kumarmn@us$(echo .)ibm.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=michaele@au1$(echo .)ibm.com \
--cc=mikey@neuling$(echo .)org \
--cc=mrochs@us$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox