From: Michael Ellerman <mpe@ellerman•id.au>
To: cuigaosheng <cuigaosheng1@huawei•com>,
LEROY Christophe <christophe.leroy2@cs-soprasteria•com>,
"npiggin@gmail•com" <npiggin@gmail•com>,
"naveen@kernel•org" <naveen@kernel•org>,
"akpm@linux-foundation•org" <akpm@linux-foundation•org>,
"david@redhat•com" <david@redhat•com>,
"Liam.Howlett@oracle•com" <Liam.Howlett@oracle•com>,
"tglx@linutronix•de" <tglx@linutronix•de>,
"bgray@linux•ibm.com" <bgray@linux•ibm.com>,
"joel@jms•id.au" <joel@jms•id.au>,
"bhelgaas@google•com" <bhelgaas@google•com>
Cc: "linuxppc-dev@lists•ozlabs.org" <linuxppc-dev@lists•ozlabs.org>
Subject: Re: [PATCH -next 1/4] powerpc: Remove obsoleted declaration for _get_SP
Date: Fri, 30 Aug 2024 20:41:13 +1000 [thread overview]
Message-ID: <87h6b2e1iu.fsf@mail.lhotse> (raw)
In-Reply-To: <48668764-8a8f-98f8-909a-8406207499d7@huawei.com>
cuigaosheng <cuigaosheng1@huawei•com> writes:
> On 2024/8/22 22:16, LEROY Christophe wrote:
>>
>> Le 22/08/2024 à 15:06, Gaosheng Cui a écrit :
>>> [Vous ne recevez pas souvent de courriers de cuigaosheng1@huawei•com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]
>>>
>>> The _get_SP() have been removed since
>>> commit 917f0af9e5a9 ("powerpc: Remove arch/ppc and include/asm-ppc"),
>>> and now it is useless, so remove it.
>> Not sure that commit is relevant since it relates to arch/ppc/ not
>> arch/powerpc/
>>
>> For arch/powerpc/ I think it is commit f4db196717c6 ("[POWERPC] Remove
>> _get_SP")
>
> In commit 1da177e4c3f4, linux implemented the _get_SP function in misc.S
> and declared and use it in arch/ppc/kernel/process.c, the declaration
> of _get_SP in arch/powerpc/kernel/process.c was introduced in commit
> 14cf11af6cf608, but at this time arch/powerpc/kernel/misc_32.S has not
> been introduced yet，so I think the declaration belongs to _get_SP in the
> misc.S，it have been removed since commit 917f0af9e5a9.
It's true that in
14cf11af6cf6 ("powerpc: Merge enough to start building in arch/powerpc.")
there was no _get_SP() in arch/powerpc, and the build used the one in
arch/ppc, and so at that point the prototype in
arch/powerpc/kernel/process.c was for the implementation in arch/ppc.
But in commit
e7e2d2da2638 ("powerpc: Don't compile in arch/ppc/kernel for 32-bit ARCH=powerpc")
we stopped building arch/ppc/kernel as part of the powerpc build.
So from then on the prototype was for the implementation in
arch/powerpc. If we check out e7e2d2da2638 and grep in arch/powerpc for _get_SP:
$ git grep -w _get_SP arch/powerpc/ include/asm-powerpc/
arch/powerpc/kernel/misc_32.S:_GLOBAL(_get_SP)
arch/powerpc/kernel/process.c:extern unsigned long _get_SP(void);
So it was indeed f4db196717c6 ("[POWERPC] Remove _get_SP") that removed
the implementation this prototype was referring to.
I'll update the change log, no need to send a v2.
cheers
next prev parent reply other threads:[~2024-08-30 10:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 13:06 [PATCH -next 0/4] Remove obsoleted declaration for powerpc Gaosheng Cui
2024-08-22 13:06 ` [PATCH -next 1/4] powerpc: Remove obsoleted declaration for _get_SP Gaosheng Cui
2024-08-22 14:16 ` LEROY Christophe
2024-08-22 15:25 ` cuigaosheng
2024-08-23 16:40 ` Christophe Leroy
2024-08-30 10:41 ` Michael Ellerman [this message]
2024-08-22 13:06 ` [PATCH -next 2/4] powerpc: Remove obsoleted declaration for maple_calibrate_decr Gaosheng Cui
2024-08-22 13:06 ` [PATCH -next 3/4] powerpc: Remove obsoleted declaration for pas_pci_irq_fixup Gaosheng Cui
2024-08-22 13:06 ` [PATCH -next 4/4] powerpc: Remove obsoleted declarations for use_cop and drop_cop Gaosheng Cui
2024-09-06 11:52 ` [PATCH -next 0/4] Remove obsoleted declaration for powerpc Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6b2e1iu.fsf@mail.lhotse \
--to=mpe@ellerman$(echo .)id.au \
--cc=Liam.Howlett@oracle$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=bgray@linux$(echo .)ibm.com \
--cc=bhelgaas@google$(echo .)com \
--cc=christophe.leroy2@cs-soprasteria$(echo .)com \
--cc=cuigaosheng1@huawei$(echo .)com \
--cc=david@redhat$(echo .)com \
--cc=joel@jms$(echo .)id.au \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=naveen@kernel$(echo .)org \
--cc=npiggin@gmail$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox