* [PATCH -next 1/4] powerpc: Remove obsoleted declaration for _get_SP
2024-08-22 13:06 [PATCH -next 0/4] Remove obsoleted declaration for powerpc Gaosheng Cui
@ 2024-08-22 13:06 ` Gaosheng Cui
2024-08-22 14:16 ` LEROY Christophe
2024-08-22 13:06 ` [PATCH -next 2/4] powerpc: Remove obsoleted declaration for maple_calibrate_decr Gaosheng Cui
` (3 subsequent siblings)
4 siblings, 1 reply; 10+ messages in thread
From: Gaosheng Cui @ 2024-08-22 13:06 UTC (permalink / raw)
To: mpe, npiggin, christophe.leroy, naveen, akpm, david, Liam.Howlett,
tglx, cuigaosheng1, bgray, joel, bhelgaas
Cc: linuxppc-dev
The _get_SP() have been removed since
commit 917f0af9e5a9 ("powerpc: Remove arch/ppc and include/asm-ppc"),
and now it is useless, so remove it.
Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei•com>
---
arch/powerpc/kernel/process.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c
index 3b506d4c55f3..e7b70c2cc001 100644
--- a/arch/powerpc/kernel/process.c
+++ b/arch/powerpc/kernel/process.c
@@ -72,8 +72,6 @@
#define TM_DEBUG(x...) do { } while(0)
#endif
-extern unsigned long _get_SP(void);
-
#ifdef CONFIG_PPC_TRANSACTIONAL_MEM
/*
* Are we running in "Suspend disabled" mode? If so we have to block any
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH -next 1/4] powerpc: Remove obsoleted declaration for _get_SP
2024-08-22 13:06 ` [PATCH -next 1/4] powerpc: Remove obsoleted declaration for _get_SP Gaosheng Cui
@ 2024-08-22 14:16 ` LEROY Christophe
2024-08-22 15:25 ` cuigaosheng
0 siblings, 1 reply; 10+ messages in thread
From: LEROY Christophe @ 2024-08-22 14:16 UTC (permalink / raw)
To: Gaosheng Cui, mpe@ellerman•id.au, npiggin@gmail•com,
naveen@kernel•org, akpm@linux-foundation•org, david@redhat•com,
Liam.Howlett@oracle•com, tglx@linutronix•de, bgray@linux•ibm.com,
joel@jms•id.au, bhelgaas@google•com
Cc: linuxppc-dev@lists•ozlabs.org
Le 22/08/2024 à 15:06, Gaosheng Cui a écrit :
> [Vous ne recevez pas souvent de courriers de cuigaosheng1@huawei•com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]
>
> The _get_SP() have been removed since
> commit 917f0af9e5a9 ("powerpc: Remove arch/ppc and include/asm-ppc"),
> and now it is useless, so remove it.
Not sure that commit is relevant since it relates to arch/ppc/ not
arch/powerpc/
For arch/powerpc/ I think it is commit f4db196717c6 ("[POWERPC] Remove
_get_SP")
>
> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei•com>
> ---
> arch/powerpc/kernel/process.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c
> index 3b506d4c55f3..e7b70c2cc001 100644
> --- a/arch/powerpc/kernel/process.c
> +++ b/arch/powerpc/kernel/process.c
> @@ -72,8 +72,6 @@
> #define TM_DEBUG(x...) do { } while(0)
> #endif
>
> -extern unsigned long _get_SP(void);
> -
> #ifdef CONFIG_PPC_TRANSACTIONAL_MEM
> /*
> * Are we running in "Suspend disabled" mode? If so we have to block any
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH -next 1/4] powerpc: Remove obsoleted declaration for _get_SP
2024-08-22 14:16 ` LEROY Christophe
@ 2024-08-22 15:25 ` cuigaosheng
2024-08-23 16:40 ` Christophe Leroy
2024-08-30 10:41 ` Michael Ellerman
0 siblings, 2 replies; 10+ messages in thread
From: cuigaosheng @ 2024-08-22 15:25 UTC (permalink / raw)
To: LEROY Christophe, mpe@ellerman•id.au, npiggin@gmail•com,
naveen@kernel•org, akpm@linux-foundation•org, david@redhat•com,
Liam.Howlett@oracle•com, tglx@linutronix•de, bgray@linux•ibm.com,
joel@jms•id.au, bhelgaas@google•com
Cc: linuxppc-dev@lists•ozlabs.org
On 2024/8/22 22:16, LEROY Christophe wrote:
>
> Le 22/08/2024 à 15:06, Gaosheng Cui a écrit :
>> [Vous ne recevez pas souvent de courriers de cuigaosheng1@huawei•com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]
>>
>> The _get_SP() have been removed since
>> commit 917f0af9e5a9 ("powerpc: Remove arch/ppc and include/asm-ppc"),
>> and now it is useless, so remove it.
> Not sure that commit is relevant since it relates to arch/ppc/ not
> arch/powerpc/
>
> For arch/powerpc/ I think it is commit f4db196717c6 ("[POWERPC] Remove
> _get_SP")
In commit 1da177e4c3f4, linux implemented the _get_SP function in misc.S
and declared and use it in arch/ppc/kernel/process.c, the declaration
of _get_SP in arch/powerpc/kernel/process.c was introduced in commit
14cf11af6cf608, but at this time arch/powerpc/kernel/misc_32.S has not
been introduced yet，so I think the declaration belongs to _get_SP in the
misc.S，it have been removed since commit 917f0af9e5a9.
In addition, commit f4db196717c6 is v2.6.22 but 917f0af9e5a9 is v2.6.27, so I think
it is commit 917f0af9e5a9.
anything others？thanks very much.
>> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei•com>
>> ---
>> arch/powerpc/kernel/process.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c
>> index 3b506d4c55f3..e7b70c2cc001 100644
>> --- a/arch/powerpc/kernel/process.c
>> +++ b/arch/powerpc/kernel/process.c
>> @@ -72,8 +72,6 @@
>> #define TM_DEBUG(x...) do { } while(0)
>> #endif
>>
>> -extern unsigned long _get_SP(void);
>> -
>> #ifdef CONFIG_PPC_TRANSACTIONAL_MEM
>> /*
>> * Are we running in "Suspend disabled" mode? If so we have to block any
>> --
>> 2.25.1
>>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH -next 1/4] powerpc: Remove obsoleted declaration for _get_SP
2024-08-22 15:25 ` cuigaosheng
@ 2024-08-23 16:40 ` Christophe Leroy
2024-08-30 10:41 ` Michael Ellerman
1 sibling, 0 replies; 10+ messages in thread
From: Christophe Leroy @ 2024-08-23 16:40 UTC (permalink / raw)
To: cuigaosheng, mpe@ellerman•id.au, npiggin@gmail•com,
naveen@kernel•org, akpm@linux-foundation•org, david@redhat•com,
Liam.Howlett@oracle•com, tglx@linutronix•de, bgray@linux•ibm.com,
joel@jms•id.au, bhelgaas@google•com
Cc: linuxppc-dev@lists•ozlabs.org
Le 22/08/2024 à 17:25, cuigaosheng a écrit :
> [Vous ne recevez pas souvent de courriers de cuigaosheng1@huawei•com.
> Découvrez pourquoi ceci est important à
> https://aka.ms/LearnAboutSenderIdentification ]
>
> On 2024/8/22 22:16, LEROY Christophe wrote:
>>
>> Le 22/08/2024 à 15:06, Gaosheng Cui a écrit :
>>> [Vous ne recevez pas souvent de courriers de cuigaosheng1@huawei•com.
>>> Découvrez pourquoi ceci est important à
>>> https://aka.ms/LearnAboutSenderIdentification ]
>>>
>>> The _get_SP() have been removed since
>>> commit 917f0af9e5a9 ("powerpc: Remove arch/ppc and include/asm-ppc"),
>>> and now it is useless, so remove it.
>> Not sure that commit is relevant since it relates to arch/ppc/ not
>> arch/powerpc/
>>
>> For arch/powerpc/ I think it is commit f4db196717c6 ("[POWERPC] Remove
>> _get_SP")
>
> In commit 1da177e4c3f4, linux implemented the _get_SP function in misc.S
> and declared and use it in arch/ppc/kernel/process.c, the declaration
> of _get_SP in arch/powerpc/kernel/process.c was introduced in commit
> 14cf11af6cf608, but at this time arch/powerpc/kernel/misc_32.S has not
> been introduced yet，so I think the declaration belongs to _get_SP in the
> misc.S，it have been removed since commit 917f0af9e5a9.
>
> In addition, commit f4db196717c6 is v2.6.22 but 917f0af9e5a9 is v2.6.27,
> so I think
> it is commit 917f0af9e5a9.
Nevermind
Reviewed-by: Christophe Leroy <christophe.leroy@csgroup•eu>
>
> anything others？thanks very much.
>
>>> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei•com>
>>> ---
>>> arch/powerpc/kernel/process.c | 2 --
>>> 1 file changed, 2 deletions(-)
>>>
>>> diff --git a/arch/powerpc/kernel/process.c
>>> b/arch/powerpc/kernel/process.c
>>> index 3b506d4c55f3..e7b70c2cc001 100644
>>> --- a/arch/powerpc/kernel/process.c
>>> +++ b/arch/powerpc/kernel/process.c
>>> @@ -72,8 +72,6 @@
>>> #define TM_DEBUG(x...) do { } while(0)
>>> #endif
>>>
>>> -extern unsigned long _get_SP(void);
>>> -
>>> #ifdef CONFIG_PPC_TRANSACTIONAL_MEM
>>> /*
>>> * Are we running in "Suspend disabled" mode? If so we have to
>>> block any
>>> --
>>> 2.25.1
>>>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH -next 1/4] powerpc: Remove obsoleted declaration for _get_SP
2024-08-22 15:25 ` cuigaosheng
2024-08-23 16:40 ` Christophe Leroy
@ 2024-08-30 10:41 ` Michael Ellerman
1 sibling, 0 replies; 10+ messages in thread
From: Michael Ellerman @ 2024-08-30 10:41 UTC (permalink / raw)
To: cuigaosheng, LEROY Christophe, npiggin@gmail•com,
naveen@kernel•org, akpm@linux-foundation•org, david@redhat•com,
Liam.Howlett@oracle•com, tglx@linutronix•de, bgray@linux•ibm.com,
joel@jms•id.au, bhelgaas@google•com
Cc: linuxppc-dev@lists•ozlabs.org
cuigaosheng <cuigaosheng1@huawei•com> writes:
> On 2024/8/22 22:16, LEROY Christophe wrote:
>>
>> Le 22/08/2024 à 15:06, Gaosheng Cui a écrit :
>>> [Vous ne recevez pas souvent de courriers de cuigaosheng1@huawei•com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]
>>>
>>> The _get_SP() have been removed since
>>> commit 917f0af9e5a9 ("powerpc: Remove arch/ppc and include/asm-ppc"),
>>> and now it is useless, so remove it.
>> Not sure that commit is relevant since it relates to arch/ppc/ not
>> arch/powerpc/
>>
>> For arch/powerpc/ I think it is commit f4db196717c6 ("[POWERPC] Remove
>> _get_SP")
>
> In commit 1da177e4c3f4, linux implemented the _get_SP function in misc.S
> and declared and use it in arch/ppc/kernel/process.c, the declaration
> of _get_SP in arch/powerpc/kernel/process.c was introduced in commit
> 14cf11af6cf608, but at this time arch/powerpc/kernel/misc_32.S has not
> been introduced yet，so I think the declaration belongs to _get_SP in the
> misc.S，it have been removed since commit 917f0af9e5a9.
It's true that in
14cf11af6cf6 ("powerpc: Merge enough to start building in arch/powerpc.")
there was no _get_SP() in arch/powerpc, and the build used the one in
arch/ppc, and so at that point the prototype in
arch/powerpc/kernel/process.c was for the implementation in arch/ppc.
But in commit
e7e2d2da2638 ("powerpc: Don't compile in arch/ppc/kernel for 32-bit ARCH=powerpc")
we stopped building arch/ppc/kernel as part of the powerpc build.
So from then on the prototype was for the implementation in
arch/powerpc. If we check out e7e2d2da2638 and grep in arch/powerpc for _get_SP:
$ git grep -w _get_SP arch/powerpc/ include/asm-powerpc/
arch/powerpc/kernel/misc_32.S:_GLOBAL(_get_SP)
arch/powerpc/kernel/process.c:extern unsigned long _get_SP(void);
So it was indeed f4db196717c6 ("[POWERPC] Remove _get_SP") that removed
the implementation this prototype was referring to.
I'll update the change log, no need to send a v2.
cheers
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH -next 2/4] powerpc: Remove obsoleted declaration for maple_calibrate_decr
2024-08-22 13:06 [PATCH -next 0/4] Remove obsoleted declaration for powerpc Gaosheng Cui
2024-08-22 13:06 ` [PATCH -next 1/4] powerpc: Remove obsoleted declaration for _get_SP Gaosheng Cui
@ 2024-08-22 13:06 ` Gaosheng Cui
2024-08-22 13:06 ` [PATCH -next 3/4] powerpc: Remove obsoleted declaration for pas_pci_irq_fixup Gaosheng Cui
` (2 subsequent siblings)
4 siblings, 0 replies; 10+ messages in thread
From: Gaosheng Cui @ 2024-08-22 13:06 UTC (permalink / raw)
To: mpe, npiggin, christophe.leroy, naveen, akpm, david, Liam.Howlett,
tglx, cuigaosheng1, bgray, joel, bhelgaas
Cc: linuxppc-dev
The maple_calibrate_decr() have been removed since
commit 10f7e7c15e6c ("[PATCH] ppc64: consolidate calibrate_decr
implementations"), and now it is useless, so remove it.
Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei•com>
---
arch/powerpc/platforms/maple/maple.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/powerpc/platforms/maple/maple.h b/arch/powerpc/platforms/maple/maple.h
index 4f358b55c341..8ddbaa4ebd0b 100644
--- a/arch/powerpc/platforms/maple/maple.h
+++ b/arch/powerpc/platforms/maple/maple.h
@@ -7,7 +7,6 @@
extern int maple_set_rtc_time(struct rtc_time *tm);
extern void maple_get_rtc_time(struct rtc_time *tm);
extern time64_t maple_get_boot_time(void);
-extern void maple_calibrate_decr(void);
extern void maple_pci_init(void);
extern void maple_pci_irq_fixup(struct pci_dev *dev);
extern int maple_pci_get_legacy_ide_irq(struct pci_dev *dev, int channel);
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH -next 3/4] powerpc: Remove obsoleted declaration for pas_pci_irq_fixup
2024-08-22 13:06 [PATCH -next 0/4] Remove obsoleted declaration for powerpc Gaosheng Cui
2024-08-22 13:06 ` [PATCH -next 1/4] powerpc: Remove obsoleted declaration for _get_SP Gaosheng Cui
2024-08-22 13:06 ` [PATCH -next 2/4] powerpc: Remove obsoleted declaration for maple_calibrate_decr Gaosheng Cui
@ 2024-08-22 13:06 ` Gaosheng Cui
2024-08-22 13:06 ` [PATCH -next 4/4] powerpc: Remove obsoleted declarations for use_cop and drop_cop Gaosheng Cui
2024-09-06 11:52 ` [PATCH -next 0/4] Remove obsoleted declaration for powerpc Michael Ellerman
4 siblings, 0 replies; 10+ messages in thread
From: Gaosheng Cui @ 2024-08-22 13:06 UTC (permalink / raw)
To: mpe, npiggin, christophe.leroy, naveen, akpm, david, Liam.Howlett,
tglx, cuigaosheng1, bgray, joel, bhelgaas
Cc: linuxppc-dev
The pas_pci_irq_fixup() have been removed since
commit 771f7404a9de ("pasemi_mac: Move the IRQ mapping from the
PCI layer to the driver"), and now it is useless, so remove it.
Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei•com>
---
arch/powerpc/platforms/pasemi/pasemi.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/powerpc/platforms/pasemi/pasemi.h b/arch/powerpc/platforms/pasemi/pasemi.h
index 018c30665e1b..6f6743b8e48d 100644
--- a/arch/powerpc/platforms/pasemi/pasemi.h
+++ b/arch/powerpc/platforms/pasemi/pasemi.h
@@ -5,7 +5,6 @@
extern time64_t pas_get_boot_time(void);
extern void pas_pci_init(void);
struct pci_dev;
-extern void pas_pci_irq_fixup(struct pci_dev *dev);
extern void pas_pci_dma_dev_setup(struct pci_dev *dev);
void __iomem *__init pasemi_pci_getcfgaddr(struct pci_dev *dev, int offset);
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH -next 4/4] powerpc: Remove obsoleted declarations for use_cop and drop_cop
2024-08-22 13:06 [PATCH -next 0/4] Remove obsoleted declaration for powerpc Gaosheng Cui
` (2 preceding siblings ...)
2024-08-22 13:06 ` [PATCH -next 3/4] powerpc: Remove obsoleted declaration for pas_pci_irq_fixup Gaosheng Cui
@ 2024-08-22 13:06 ` Gaosheng Cui
2024-09-06 11:52 ` [PATCH -next 0/4] Remove obsoleted declaration for powerpc Michael Ellerman
4 siblings, 0 replies; 10+ messages in thread
From: Gaosheng Cui @ 2024-08-22 13:06 UTC (permalink / raw)
To: mpe, npiggin, christophe.leroy, naveen, akpm, david, Liam.Howlett,
tglx, cuigaosheng1, bgray, joel, bhelgaas
Cc: linuxppc-dev
The use_cop() and drop_cop() have been removed since
commit 6ff4d3e96652 ("powerpc: Remove old unused icswx based
coprocessor support"), now they are useless, so remove them.
Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei•com>
---
arch/powerpc/include/asm/mmu_context.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/powerpc/include/asm/mmu_context.h b/arch/powerpc/include/asm/mmu_context.h
index a334a1368848..a157ab513347 100644
--- a/arch/powerpc/include/asm/mmu_context.h
+++ b/arch/powerpc/include/asm/mmu_context.h
@@ -116,9 +116,6 @@ static inline bool need_extra_context(struct mm_struct *mm, unsigned long ea)
}
#endif
-extern int use_cop(unsigned long acop, struct mm_struct *mm);
-extern void drop_cop(unsigned long acop, struct mm_struct *mm);
-
#ifdef CONFIG_PPC_BOOK3S_64
static inline void inc_mm_active_cpus(struct mm_struct *mm)
{
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH -next 0/4] Remove obsoleted declaration for powerpc
2024-08-22 13:06 [PATCH -next 0/4] Remove obsoleted declaration for powerpc Gaosheng Cui
` (3 preceding siblings ...)
2024-08-22 13:06 ` [PATCH -next 4/4] powerpc: Remove obsoleted declarations for use_cop and drop_cop Gaosheng Cui
@ 2024-09-06 11:52 ` Michael Ellerman
4 siblings, 0 replies; 10+ messages in thread
From: Michael Ellerman @ 2024-09-06 11:52 UTC (permalink / raw)
To: mpe, npiggin, christophe.leroy, naveen, akpm, david, Liam.Howlett,
tglx, bgray, joel, bhelgaas, Gaosheng Cui
Cc: linuxppc-dev
On Thu, 22 Aug 2024 21:06:05 +0800, Gaosheng Cui wrote:
> Remove obsoleted declaration for powerpc, thanks!
>
> Gaosheng Cui (4):
> powerpc: Remove obsoleted declaration for _get_SP
> powerpc: Remove obsoleted declaration for maple_calibrate_decr
> powerpc: Remove obsoleted declaration for pas_pci_irq_fixup
> powerpc: Remove obsoleted declarations for use_cop and drop_cop
>
> [...]
Applied to powerpc/next.
[1/4] powerpc: Remove obsoleted declaration for _get_SP
https://git.kernel.org/powerpc/c/dace02a9ee1921adee05bf1807a78f92ee2dea2b
[2/4] powerpc: Remove obsoleted declaration for maple_calibrate_decr
https://git.kernel.org/powerpc/c/6745c5bb2e0fe513918ce2136108a2efb92bdea1
[3/4] powerpc: Remove obsoleted declaration for pas_pci_irq_fixup
https://git.kernel.org/powerpc/c/fe16a749731e86d580acf8d43b0298dfe6d1503d
[4/4] powerpc: Remove obsoleted declarations for use_cop and drop_cop
https://git.kernel.org/powerpc/c/600d6a7e630e970624911624eb15986245b18668
cheers
^ permalink raw reply [flat|nested] 10+ messages in thread