Subject: Re: [PATCH v4 09/13] powerpc/pseries: Add papr-vpd character driver for VPD retrieval

From: Michael Ellerman <[email-masked]>
Date: Wed, 29 Nov 2023 14:13:43 +1100

Nathan Lynch <[email-masked]> writes:
> Michael Ellerman <[email-masked]> writes:
>
>> Nathan Lynch via B4 Relay <[email-masked]>
>> writes:
>>> From: Nathan Lynch <[email-masked]>
>>>
>>> PowerVM LPARs may retrieve Vital Product Data (VPD) for system
>>> components using the ibm,get-vpd RTAS function.
>> ...
>>>
>>> diff --git a/Documentation/userspace-api/ioctl/ioctl-number.rst b/Documentation/userspace-api/ioctl/ioctl-number.rst
>>> index 4ea5b837399a..a950545bf7cd 100644
>>> --- a/Documentation/userspace-api/ioctl/ioctl-number.rst
>>> +++ b/Documentation/userspace-api/ioctl/ioctl-number.rst
>>> @@ -349,6 +349,8 @@ Code  Seq#    Include File                                           Comments
>>>                                                                       <mailto:[email-masked]>
>>>  0xB1  00-1F                                                          PPPoX
>>>                                                                       <mailto:[email-masked]>
>>> +0xB2  00     arch/powerpc/include/uapi/asm/papr-vpd.h                powerpc/pseries VPD API
>>> +                                                                     <mailto:linuxppc-dev>
>>  
>> This hunk should probably go in the previous patch.
>
> The papr-sysparm driver (patch 11/13 "powerpc/pseries/papr-sysparm:
> Expose character device to user space") also adds a line to
> ioctl-number.rst. Are you saying all the additions to ioctl-number.rst
> should be contained in a single patch?

No.

I just meant that the previous patch is where we initially expose the
0xB2 value via uapi, which is the point of no return. So preferably the
documentation is updated by or before that point to reflect that the
0xB2 value is now reserved.

The change log of that patch also talks about allocating a value from
the ioctl-number table, but then doesn't update the table.

cheers