From: "Aneesh Kumar K.V" <aneesh.kumar@linux•vnet.ibm.com>
To: Balbir Singh <bsingharora@gmail•com>
Cc: linuxppc-dev@lists•ozlabs.org,
Michael Ellerman <mpe@ellerman•id.au>,
Michael Neuling <mikey@neuling•org>
Subject: Re: [PATCH] Add support for power9 in ibm_architecture_vec
Date: Wed, 15 Jun 2016 21:28:54 +0530 [thread overview]
Message-ID: <87h9cua1fl.fsf@skywalker.in.ibm.com> (raw)
In-Reply-To: <CAKTCnzmLQoBLTyE+bDqwbCTJ+zDLih1Xzm17Qf3M=8v2MBAptQ@mail.gmail.com>
Balbir Singh <bsingharora@gmail•com> writes:
> On Wed, Jun 15, 2016 at 9:17 PM, Aneesh Kumar K.V
> <aneesh.kumar@linux•vnet.ibm.com> wrote:
>> Shouldn't this be 125 + 16 ?
>
> Actually the previous patch broke it and Ben fixed it, it should have
> been 133 after adding POWER8NVL. My patch adds 16+1 (1 for the
> OV1_PPC_3_00)
>
> 133+17 = 150
>
> Michael, can you please check. I did a quick check with gdb
>
I missed that OV1_PPC_3_00 is byte 3 of option vection 1. I guess you
also need to update VECTOR_LENGHT above the option vector 1 to 3.
ie, it should be VECTOR_LENGTH(3) ?
-aneesh
next prev parent reply other threads:[~2016-06-15 15:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 8:17 [PATCH] Add support for power9 in ibm_architecture_vec Balbir Singh
2016-06-15 11:17 ` Aneesh Kumar K.V
2016-06-15 12:08 ` Balbir Singh
2016-06-15 15:58 ` Aneesh Kumar K.V [this message]
2016-06-16 0:09 ` Balbir Singh
2016-06-16 4:54 ` [PATCH][V2] " Balbir Singh
2016-06-16 5:31 ` Michael Ellerman
2016-06-16 5:47 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h9cua1fl.fsf@skywalker.in.ibm.com \
--to=aneesh.kumar@linux$(echo .)vnet.ibm.com \
--cc=bsingharora@gmail$(echo .)com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mikey@neuling$(echo .)org \
--cc=mpe@ellerman$(echo .)id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox