From: Michael Ellerman <mpe@ellerman•id.au>
To: Vignesh Balasubramanian <vigbalas@amd•com>,
linux-kernel@vger•kernel.org, linux-toolchains@vger•kernel.org
Cc: felix.willgerodt@intel•com, matz@suse•de, keescook@chromium•org,
jhb@FreeBSD•org, bpetkov@amd•com, binutils@sourceware•org,
x86@kernel•org, aneesh.kumar@kernel•org, linux-mm@kvack•org,
Vignesh Balasubramanian <vigbalas@amd•com>,
npiggin@gmail•com, naveen.n.rao@linux•ibm.com,
linuxppc-dev@lists•ozlabs.org, jinisusan.george@amd•com,
ebiederm@xmission•com
Subject: Re: [PATCH 1/1] Replace macro "ARCH_HAVE_EXTRA_ELF_NOTES" with kconfig
Date: Fri, 12 Apr 2024 22:07:39 +1000 [thread overview]
Message-ID: <87il0mdbsk.fsf@mail.lhotse> (raw)
In-Reply-To: <20240412062138.1132841-2-vigbalas@amd.com>
Vignesh Balasubramanian <vigbalas@amd•com> writes:
> "ARCH_HAVE_EXTRA_ELF_NOTES" enables an extra note section in the
> core dump. Kconfig variable is preferred over ARCH_HAVE_* macro.
>
> Co-developed-by: Jini Susan George <jinisusan.george@amd•com>
> Signed-off-by: Jini Susan George <jinisusan.george@amd•com>
> Signed-off-by: Vignesh Balasubramanian <vigbalas@amd•com>
> ---
> arch/Kconfig | 9 +++++++++
> arch/powerpc/Kconfig | 1 +
> arch/powerpc/include/asm/elf.h | 2 --
> include/linux/elf.h | 2 +-
> 4 files changed, 11 insertions(+), 3 deletions(-)
Acked-by: Michael Ellerman <mpe@ellerman•id.au> (powerpc)
cheers
> diff --git a/arch/Kconfig b/arch/Kconfig
> index 9f066785bb71..143f021c8a76 100644
> --- a/arch/Kconfig
> +++ b/arch/Kconfig
> @@ -502,6 +502,15 @@ config MMU_LAZY_TLB_SHOOTDOWN
> config ARCH_HAVE_NMI_SAFE_CMPXCHG
> bool
>
> +config ARCH_HAVE_EXTRA_ELF_NOTES
> + bool
> + help
> + An architecture should select this in order to enable adding an
> + arch-specific ELF note section to core files. It must provide two
> + functions: elf_coredump_extra_notes_size() and
> + elf_coredump_extra_notes_write() which are invoked by the ELF core
> + dumper.
> +
> config ARCH_HAS_NMI_SAFE_THIS_CPU_OPS
> bool
>
> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> index 1c4be3373686..c45fa9d7fb76 100644
> --- a/arch/powerpc/Kconfig
> +++ b/arch/powerpc/Kconfig
> @@ -156,6 +156,7 @@ config PPC
> select ARCH_HAS_UACCESS_FLUSHCACHE
> select ARCH_HAS_UBSAN
> select ARCH_HAVE_NMI_SAFE_CMPXCHG
> + select ARCH_HAVE_EXTRA_ELF_NOTES if SPU_BASE
> select ARCH_KEEP_MEMBLOCK
> select ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE if PPC_RADIX_MMU
> select ARCH_MIGHT_HAVE_PC_PARPORT
> diff --git a/arch/powerpc/include/asm/elf.h b/arch/powerpc/include/asm/elf.h
> index 79f1c480b5eb..bb4b94444d3e 100644
> --- a/arch/powerpc/include/asm/elf.h
> +++ b/arch/powerpc/include/asm/elf.h
> @@ -127,8 +127,6 @@ extern int arch_setup_additional_pages(struct linux_binprm *bprm,
> /* Notes used in ET_CORE. Note name is "SPU/<fd>/<filename>". */
> #define NT_SPU 1
>
> -#define ARCH_HAVE_EXTRA_ELF_NOTES
> -
> #endif /* CONFIG_SPU_BASE */
>
> #ifdef CONFIG_PPC64
> diff --git a/include/linux/elf.h b/include/linux/elf.h
> index c9a46c4e183b..5c402788da19 100644
> --- a/include/linux/elf.h
> +++ b/include/linux/elf.h
> @@ -65,7 +65,7 @@ extern Elf64_Dyn _DYNAMIC [];
> struct file;
> struct coredump_params;
>
> -#ifndef ARCH_HAVE_EXTRA_ELF_NOTES
> +#ifndef CONFIG_ARCH_HAVE_EXTRA_ELF_NOTES
> static inline int elf_coredump_extra_notes_size(void) { return 0; }
> static inline int elf_coredump_extra_notes_write(struct coredump_params *cprm) { return 0; }
> #else
> --
> 2.34.1
next prev parent reply other threads:[~2024-04-12 12:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 6:21 [PATCH 0/1] Replace the macro "ARCH_HAVE_EXTRA_ELF_NOTES" with kconfig Vignesh Balasubramanian
2024-04-12 6:21 ` [PATCH 1/1] Replace " Vignesh Balasubramanian
2024-04-12 12:07 ` Michael Ellerman [this message]
2024-04-22 8:15 ` Florian Weimer
2024-04-15 18:03 ` [PATCH 0/1] Replace the " Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87il0mdbsk.fsf@mail.lhotse \
--to=mpe@ellerman$(echo .)id.au \
--cc=aneesh.kumar@kernel$(echo .)org \
--cc=binutils@sourceware$(echo .)org \
--cc=bpetkov@amd$(echo .)com \
--cc=ebiederm@xmission$(echo .)com \
--cc=felix.willgerodt@intel$(echo .)com \
--cc=jhb@FreeBSD$(echo .)org \
--cc=jinisusan.george@amd$(echo .)com \
--cc=keescook@chromium$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-toolchains@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=matz@suse$(echo .)de \
--cc=naveen.n.rao@linux$(echo .)ibm.com \
--cc=npiggin@gmail$(echo .)com \
--cc=vigbalas@amd$(echo .)com \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox